View Issue Details

IDProjectCategoryView StatusLast Update
0009950Talerqtartpublic2025-08-31 17:09
Reporterfefe Assigned Toavalos Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version1.0 stretch goalsFixed in Version1.0 stretch goals 
Summary0009950: unchecked malloc can lead to crash
DescriptionIn tart_module.c:

 510 hash = malloc(hash_len);
 511
 512 if (crypto_pwhash(hash,
 513 hash_len,
 514 (const char*) pw,
 515 pw_len,
 516 salt,
 517 iters,
 518 mem_size * 1024,
 519 crypto_pwhash_ALG_ARGON2ID13) != 0) {

malloc can fail and return NULL, and crypto_pwhash does not check if hash is NULL before writing to it.
Tagssecurity

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

avalos

2025-05-15 13:48

developer   ~0024918

commit 991116d47edc8cd3a71d658f57104c92d03baeee
Author: Iván Ávalos <avalos@disroot.org>
Date: Thu May 15 15:48:11 2025 +0200

    fix unchecked malloc
    
    bug 0009950

Issue History

Date ModifiedUsernameFieldChange
2025-05-13 11:51fefeNew Issue
2025-05-13 12:39Christian GrothoffAssigned To => avalos
2025-05-13 12:39Christian GrothoffStatusnew => assigned
2025-05-15 11:39Christian GrothoffTag Attached: security
2025-05-15 11:41Christian GrothoffTarget Version => 1.0 stretch goals
2025-05-15 13:48avalosNote Added: 0024918
2025-05-15 13:49avalosStatusassigned => informing
2025-05-15 13:49avalosResolutionopen => fixed
2025-05-20 18:28Christian GrothoffFixed in Version => 1.0 stretch goals
2025-08-31 17:09Christian GrothoffStatusinforming => closed