View Issue Details

IDProjectCategoryView StatusLast Update
0009916Talerexchangepublic2025-05-10 02:10
ReporterFlorian Dold Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version1.0Fixed in Version1.0 
Summary0009916: exchange does not validate form outputs
DescriptionDespite the following config section:

[kyc-check-form-vqf-902.9]
TYPE = FORM
FORM_NAME = vqf_902_9_customer
DESCRIPTION = "Supply VQF form 902.9"
DESCRIPTION_I18N = {"de":"Formular VQF 902.9 hochladen"}
OUTPUTS = SUBMITTED_BY CONTRACTING_PARTY BENEFICIAL_OWNER_LIST
FALLBACK = preserve-investigate


the exchange happily accepts a form submission without those fields.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Florian Dold

2025-05-08 21:16

manager   ~0024857

Note that fixing this should first cause the following test to *fail*:

$ taler-harness run-integrationtests tops-aml-measures

Christian Grothoff

2025-05-09 12:18

manager   ~0024865

Test fails as of 07008e3fb..8335fc5e2:

2025-05-09T12:18:17.939Z testrunner.ts INFO done test tops-aml-measures: fail
2025-05-09T12:18:17.946Z testrunner.ts INFO process exited code=0 signal=null
-- test steps --
STEP env-setup-done
FAIL Unexpected HTTP status 400 in response
-- end --
parent: got result {"name":"tops-aml-measures","timeSec":3.571,"status":"fail"}
See /tmp/taler-integrationtests-G0aMNm/results.json for details
Logs can be found in /tmp/taler-integrationtests-G0aMNm
Skipped: 0/1
Failed: 1/1
Passed: 0/1

Florian Dold

2025-05-09 15:41

manager   ~0024869

commit 008c4a709ea47b8ffb799785daf7b068df83bd30 (HEAD -> master)
Author: Florian Dold <florian@dold.me>
Date: Fri May 9 17:40:43 2025 +0200

    harness: make tops-aml-measures pass under stronger validation in exchange

Issue History

Date ModifiedUsernameFieldChange
2025-05-08 21:14Florian DoldNew Issue
2025-05-08 21:16Florian DoldNote Added: 0024857
2025-05-09 12:18Christian GrothoffNote Added: 0024865
2025-05-09 12:19Christian GrothoffAssigned To => Florian Dold
2025-05-09 12:19Christian GrothoffStatusnew => assigned
2025-05-09 12:19Christian GrothoffProduct Version => git (master)
2025-05-09 12:19Christian GrothoffTarget Version1.0 stretch goals => 1.0
2025-05-09 15:41Florian DoldStatusassigned => informing
2025-05-09 15:41Florian DoldResolutionopen => fixed
2025-05-09 15:41Florian DoldNote Added: 0024869
2025-05-09 15:58Christian GrothoffFixed in Version => 1.0
2025-05-10 02:10Christian GrothoffStatusinforming => closed