View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0009861 | Taler | exchange | public | 2025-05-03 23:14 | 2025-05-10 02:10 |
| Reporter | Florian Dold | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 1.0 | Fixed in Version | 1.0 | ||
| Summary | 0009861: exchange does not report (balance) limits in /kyc-check response | ||||
| Description | I noticed this because subsequent balance thresholds don't work properly with the wallet, as the wallet takes those from the limits. Upon further investigation, it seems like /kyc-check doesn't return any limits, even when they're clearly exposed. | ||||
| Steps To Reproduce | taler-harness run-integrationtests kyc-decisions This test doesn't use balance thresholds, but it makes a /kyc-check request, and it seems despite a KYC decision (with exposed rules!), the limits in the response are empty. | ||||
| Tags | No tags attached. | ||||
| Eh, the only POST to /decision I see sets a *DEPOSIT* and *WITHDRAW* limit, not a BALANCE limit. Note that for *wallets* we never report DEPOST/WITHDRAW limits, as they only apply for *accounts*. Sure, we might (in the future) 400 on such (bad) decisions (with rules that simply don't apply to the account type), but that's another story. Note that by POSTing the decision, you ALSO override any default BALANCE limits that might have applied. Oh, and the test *passes*. | |
| The following commit also adds a BALANCE limit in the same decision. The exchange still returns an empty limits list. commit 2d1d55b4fab14a3f4590794eb04bfedc1b3ac32a (HEAD -> master, origin/master, origin/HEAD) Author: Florian Dold <florian@dold.me> Date: Mon May 5 12:23:56 2025 +0200 harness: also add BALANCE rule in kyc-decisions test | |
| Fix committed to master branch. | |
| Fixed in 7456ab2b9..4e8373945 | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2025-05-03 23:14 | Florian Dold | New Issue | |
| 2025-05-04 23:34 | Christian Grothoff | Status | new => implementing |
| 2025-05-04 23:34 | Christian Grothoff | Product Version | => git (master) |
| 2025-05-04 23:42 | Christian Grothoff | Note Added: 0024769 | |
| 2025-05-04 23:42 | Christian Grothoff | Assigned To | => Florian Dold |
| 2025-05-04 23:42 | Christian Grothoff | Status | implementing => feedback |
| 2025-05-05 10:24 | Florian Dold | Note Added: 0024771 | |
| 2025-05-05 10:24 | Florian Dold | Assigned To | Florian Dold => Christian Grothoff |
| 2025-05-05 10:24 | Florian Dold | Status | feedback => assigned |
| 2025-05-05 19:01 | Christian Grothoff | ||
| 2025-05-05 19:01 | Christian Grothoff | Note Added: 0024786 | |
| 2025-05-05 19:01 | Christian Grothoff | Status | assigned => informing |
| 2025-05-05 19:01 | Christian Grothoff | Resolution | open => fixed |
| 2025-05-05 19:02 | Christian Grothoff | Note Added: 0024787 | |
| 2025-05-05 19:02 | Christian Grothoff | Fixed in Version | => 1.0 |
| 2025-05-05 19:02 | Christian Grothoff | Target Version | 1.0 stretch goals => 1.0 |
| 2025-05-10 02:10 | Christian Grothoff | Status | informing => closed |