View Issue Details

IDProjectCategoryView StatusLast Update
0009836Talerwallet (Android App)public2025-05-10 02:10
ReporterFlorian Dold Assigned Toavalos Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version1.0Fixed in Version1.0 
Summary0009836: Android wallet should not show pop-up when confirmPay returns pending status
DescriptionThat is going to be the normal return value in the future. The status after confirmPay should entirely depend on the transaction details based on the transaction ID.
Tagsux

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

avalos

2025-04-30 20:54

developer   ~0024739

What was the popup again?
Is this about confirmPay for merchant payments?

Florian Dold

2025-05-03 22:35

manager   ~0024749

Yes, it's about confirmPay for merchant payment.

It's the popup that we see when confirmPay returns the pending response. In future versions of wallet-core, confirmPay will *always* return the pending response, requiring the UI to show the status based on the transaction ID.

avalos

2025-05-04 20:40

developer   ~0024762

Not showing any popup anymore:

is PayStatus.Pending -> {
    showLoading(false)
    paymentManager.resetPayStatus()
    navigateToTransaction(payStatus.transactionId)
}

commit 989b16fdee2494efb200c32274ebdf2ea72f8fde
Author: Iván Ávalos <avalos@disroot.org>
Date: Sun May 4 22:38:11 2025 +0200

    [wallet] remove error popup on confirmPay pending response
    
    bug 0009836

Issue History

Date ModifiedUsernameFieldChange
2025-04-30 20:16Florian DoldNew Issue
2025-04-30 20:19Christian GrothoffTag Attached: ux
2025-04-30 20:19Christian GrothoffAssigned To => avalos
2025-04-30 20:19Christian GrothoffStatusnew => assigned
2025-04-30 20:19Christian GrothoffProduct Version => git (master)
2025-04-30 20:54avalosNote Added: 0024739
2025-04-30 20:54avalosAssigned Toavalos => Florian Dold
2025-04-30 20:54avalosStatusassigned => feedback
2025-05-03 22:35Florian DoldNote Added: 0024749
2025-05-03 22:35Florian DoldAssigned ToFlorian Dold => avalos
2025-05-04 20:40avalosNote Added: 0024762
2025-05-04 20:40avalosStatusfeedback => informing
2025-05-04 20:40avalosResolutionopen => fixed
2025-05-04 21:17Christian GrothoffFixed in Version => 1.0
2025-05-04 21:17Christian GrothoffTarget Version1.0 stretch goals => 1.0
2025-05-10 02:10Christian GrothoffStatusinforming => closed