View Issue Details

IDProjectCategoryView StatusLast Update
0009821Talerwallet-corepublic2025-08-31 17:09
ReporterAntoine A Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version1.0 stretch goalsFixed in Version1.0 stretch goals 
Summary0009821: Refactor notifications handling
DescriptionWe currently pass a lot of notifications to delay their propagation until the DB transaction is committed. This creates a lot of boilerplate and it's easy to miss some notification because typescript doesn't warn of unused ones.
I think it's better to store notifications in the context of the transaction and have the wallet propagate them at the end.
It's also an opportunity to group notifications propagation and improve performance.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

child of 0009823 closedAntoine A Refactoring and cleaning 

Activities

Antoine A

2025-04-30 14:24

manager   ~0024714

Done in https://git.taler.net/taler-typescript-core.git/commit/?h=dev/antoine/clean-notification
Waiting for 1.0 release before breaking everything

Antoine A

2025-06-07 13:12

manager   ~0025182

Fixed in 9c5bfb3f9417c7fb8177285c65ad05909dd46aaa

Issue History

Date ModifiedUsernameFieldChange
2025-04-30 14:23Antoine ANew Issue
2025-04-30 14:23Antoine AStatusnew => assigned
2025-04-30 14:23Antoine AAssigned To => Antoine A
2025-04-30 14:24Antoine ANote Added: 0024714
2025-04-30 15:05Antoine ARelationship addedchild of 0009823
2025-06-07 13:12Antoine AAssigned ToAntoine A => Florian Dold
2025-06-07 13:12Antoine AStatusassigned => informing
2025-06-07 13:12Antoine AResolutionopen => fixed
2025-06-07 13:12Antoine ANote Added: 0025182
2025-06-07 15:27Christian GrothoffProduct Version => git (master)
2025-06-07 15:27Christian GrothoffFixed in Version => 1.0 stretch goals
2025-06-07 15:27Christian GrothoffTarget Versionpost-1.0 => 1.0 stretch goals
2025-08-31 17:09Christian GrothoffStatusinforming => closed