View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0009797 | Taler | taler-harness | public | 2025-04-25 23:14 | 2025-05-10 02:13 |
| Reporter | Florian Dold | Assigned To | Florian Dold | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Target Version | 1.0 | Fixed in Version | 1.0 | ||
| Summary | 0009797: harness test kyc-merchant-deposit-rewrite unclear | ||||
| Description | It's unclear to me whether the test (originally written by Sebastian) is expected to even work like it is currently written or not. The test starts with a deposit limit for merchants of zero. The AML officer then lifts the limit for a particular account. Then the test expects the merchant backend to update the KYC status ("GET .../private/kyc") by running kyccheck and depositcheck in test mode (-t). Is this even expected to work? The other (passing!) integration test triggers the KYC status update by POSTing an order. | ||||
| Tags | No tags attached. | ||||
| Yes, it should work, but again possibly with timetravel. taler-merchant-kyccheck is supposed to check about our exchange KYC status independent of "incidents". However, the frequency is capped at once per 6h, so you'll need to timetravel taler-merchant-kyccheck at least 6h into the future. | |
| I have *not* added the time travel yet. However, the test currently times out for me directly in the first step after setup, since taler-merchant-kyccheck *hangs* despite passing "-t". Note that there is another taler-merchant-kyccheck running in the background already. You can either see from the logs that kyccheck hangs, or I can write another harness test to reproduce just the hanging. WDYT? | |
| Let me look into it. | |
| c592a1c6..924fa10a fixes the hang: we were long-polling at the exchange. With the patch, we are no longer long-polling in test mode and the process exits virtually immediately. Test still fails... | |
| Test passes now after having fixed a bad assertion in the harness. Curiously, it passes without requiring time travel. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2025-04-25 23:14 | Florian Dold | New Issue | |
| 2025-04-25 23:14 | Florian Dold | Status | new => assigned |
| 2025-04-25 23:14 | Florian Dold | Assigned To | => Christian Grothoff |
| 2025-04-26 08:38 | Christian Grothoff | Note Added: 0024683 | |
| 2025-04-26 08:38 | Christian Grothoff | Assigned To | Christian Grothoff => Florian Dold |
| 2025-04-28 21:54 | Florian Dold | Note Added: 0024700 | |
| 2025-04-28 21:54 | Florian Dold | Assigned To | Florian Dold => Christian Grothoff |
| 2025-04-28 23:09 | Christian Grothoff | Note Added: 0024703 | |
| 2025-04-28 23:30 | Christian Grothoff | Note Added: 0024704 | |
| 2025-04-28 23:31 | Christian Grothoff | Assigned To | Christian Grothoff => Florian Dold |
| 2025-04-29 12:28 | Florian Dold | Status | assigned => informing |
| 2025-04-29 12:28 | Florian Dold | Resolution | open => fixed |
| 2025-04-29 12:28 | Florian Dold | Note Added: 0024707 | |
| 2025-05-10 02:12 | Christian Grothoff | Fixed in Version | => 1.0 |
| 2025-05-10 02:13 | Christian Grothoff | Status | informing => closed |