View Issue Details

IDProjectCategoryView StatusLast Update
0009729Talerexchange KYC customer webuipublic2025-06-24 15:16
ReporterChristian Grothoff Assigned ToResolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityN/A
Status implementingResolutionopen 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Product Versiongit (master) 
Target Versionpost-1.0 
Summary0009729: gracefully handle the "upload too large" case, maybe maximum upload size could be 16 MB
DescriptionEspecially with attachments, we can go above this. In this case *Nginx* already returns the 413, the request doesn't even make it to the exchange and so the body will be in HTML and not JSON. Nevertheless, the SPA should handle this case gracefully.

Additionally, *if* the upload size _would_ exceed 16 MB (which I believe you can easily calculate), the SPA should
1) not even attempt the upload,
2) show the user an error explaining that the upload would be too big, and
3) suggest to the user to optimize the files to make them smaller *or* contact the operator.

Texts:
"Your upload would likely exceed the server's limit." (bold, title)
"Please try to optimize the size of the files you are uploading, or contact the operator for help."

Note: the limit applies to the *compressed* JSON (deflate encoding), not the plaintext JSON.

Next note: This *also* applies to the AML SPA!
Tagsux

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

sebasjm

2025-04-15 20:49

developer   ~0024567

this is kind of simple in the kyc spa, but more complex in the AML spa where we have a wizard.
The wizard saves the information in the localStorage where we have limited capacity (kind of 5mb) so we need to use another API or... prevent saving files in localStorage (which means that you loose the information if the page reloads)

Christian Grothoff

2025-04-15 21:24

manager   ~0024569

I'm confused. I didn't say you *had* to support 16MB. I guess 5 MB files could be enough for the AML SPA -- here *we* can always break up/compress/compact the file if needed. My point was to gracefully handle the "upload too large" case, and ideally prevent it early.

Issue History

Date ModifiedUsernameFieldChange
2025-04-15 12:14Christian GrothoffNew Issue
2025-04-15 12:14Christian GrothoffStatusnew => assigned
2025-04-15 12:14Christian GrothoffAssigned To => sebasjm
2025-04-15 20:49sebasjmNote Added: 0024567
2025-04-15 21:24Christian GrothoffNote Added: 0024569
2025-04-17 19:14Christian GrothoffTag Attached: ux
2025-04-17 19:15Christian GrothoffTarget Version1.0 stretch goals => post-1.0
2025-04-23 22:29Christian GrothoffAssigned Tosebasjm =>
2025-04-23 22:29Christian GrothoffStatusassigned => implementing
2025-06-24 15:16sebasjmSummarymaximum upload size is 16 MB => gracefully handle the "upload too large" case, maybe maximum upload size could be 16 MB
2026-08-23 14:17Florian DoldCategoryexchange KYC SPA => exchange KYC customer webui