View Issue Details

IDProjectCategoryView StatusLast Update
0009701Talerwallet (Android App)public2025-05-10 02:11
ReporterChristian Grothoff Assigned Toavalos Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeveritytweakReproducibilityalways
Status closedResolutionfixed 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Product Versiongit (master) 
Target Version1.0Fixed in Version1.0 
Summary0009701: 'balances' button does not work
DescriptionWhen I'm on the screen where I see a particular balance (say KUDOS or CHF) and then click on 'balances', it does NOT take me back to the entry/summary page. I have to click on the currency-drop-down to get 'back'. It's of course correct that clicking on the currency drop-down indicator takes me back to the main screen, but clicking on the 'balances' button in the main menu at the bottom should *also* do this.

iOS does this (it has a 'back' button on top for this, but *also* the main 'balances' button goes back).
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

avalos

2025-04-08 19:37

developer   ~0024451

"Balances" is not a button, it was never meant to, it is not an Android thing.

Whenever you click a balance item, the title should change to "Transactions."

However, I just noticed that the German translation is wrong, and says "Salden" in both views.
image.png (91,002 bytes)   
image.png (91,002 bytes)   
image-2.png (74,469 bytes)   
image-2.png (74,469 bytes)   
image-3.png (59,268 bytes)   
image-3.png (59,268 bytes)   
image-4.png (90,733 bytes)   
image-4.png (90,733 bytes)   

avalos

2025-04-08 19:39

developer   ~0024452

I just fixed this in Weblate, it should now say "Transaktionen."

Christian Grothoff

2025-04-08 19:43

manager   ~0024453

Eh, wait, that seems worse. What does the button say on iOS? And it is a button on iOS. As I said: please let's converge, not diverge!

Stefan

2025-04-09 08:19

reporter   ~0024460

(1) Both buttons in the iOS and the Android apps are labelled "Balances" respectively "Salden" - which is right (iOS: TalerWallet1/Localizable.xcstrings///TitleBalances, Android: balances_title).
(2) Both apps have a clickable button in the main menu which makes sense as users want to get to the balances overview page by the tip of a finger, especially when their wallets bear multiple currencies.
(3) I think Iván made the right change in Weblate (from "Salden" to "Transaktionen" for the German translation of the key transactions_title)
(4) The key transactions_title is only deployed on Android while completely missing in iOS - which is OK for the user experience
(5) IMHO we better agree with the state as it is now. I will push Iváns change from Weblate to the git repo this afternoon if nobody objects.

avalos

2025-04-09 08:35

developer   ~0024461

> Eh, wait, that seems worse. What does the button say on iOS? And it is a button on iOS. As I said: please let's converge, not diverge!

1) It is not worse, "Transactions" describes what's currently on-screen, not "Balances."
1) No, let's not converge at the expense of platform conventions, toolbar titles are NEVER buttons on Android.
2) There must be only ONE way to do something, you said that to me once also regarding a button to go back.

avalos

2025-04-09 08:40

developer   ~0024462

@Stefan I agree, regardless of the UI state itself, I believe the string `transactions_title` should say "Transactions" in all languages.

Sorry for not discussing it with you first, it was too small of a change and too obvious for me that it didn't cross my head.

Christian Grothoff

2025-04-09 08:44

manager   ~0024463

Last edited: 2025-04-09 08:45

Eh, I'm sorry, but I'm not talking about the *title* of anything here. I'm talking about the button left of the action button with the Taler-logo. In your screenshots, that's labeled "Salden" and that button is not working.

avalos

2025-04-09 09:11

developer   ~0024467

Ah okay! You're right, that button should indeed take back to the balances list, I'll fix it!

avalos

2025-04-09 09:21

developer   ~0024468

commit 34a6ecc6d2d428e8f52d1fe99960fc7acecc09f1
Author: Iván Ávalos <avalos@disroot.org>
Date: Wed Apr 9 11:20:04 2025 +0200

    [wallet] "Balances" tab now cleans selected scope
    
    bug 0009701

Issue History

Date ModifiedUsernameFieldChange
2025-04-06 09:16Christian GrothoffNew Issue
2025-04-06 09:16Christian GrothoffStatusnew => assigned
2025-04-06 09:16Christian GrothoffAssigned To => avalos
2025-04-08 19:37avalosNote Added: 0024451
2025-04-08 19:37avalosFile Added: image.png
2025-04-08 19:37avalosFile Added: image-2.png
2025-04-08 19:37avalosFile Added: image-3.png
2025-04-08 19:37avalosFile Added: image-4.png
2025-04-08 19:39avalosNote Added: 0024452
2025-04-08 19:43Christian GrothoffNote Added: 0024453
2025-04-09 08:19StefanNote Added: 0024460
2025-04-09 08:35avalosNote Added: 0024461
2025-04-09 08:40avalosNote Added: 0024462
2025-04-09 08:44Christian GrothoffNote Added: 0024463
2025-04-09 08:45Christian GrothoffNote Edited: 0024463
2025-04-09 09:11avalosNote Added: 0024467
2025-04-09 09:21avalosStatusassigned => informing
2025-04-09 09:21avalosResolutionopen => fixed
2025-04-09 09:21avalosNote Added: 0024468
2025-04-12 17:15Christian GrothoffFixed in Version => 1.0
2025-04-12 17:15Christian GrothoffTarget Version1.0 stretch goals => 1.0
2025-05-10 02:11Christian GrothoffStatusinforming => closed