| I've improved the error reporting, but IMO this is a UI problem. The UI should not let the user confirm, but instead check the transaction's state first. | |
| How do you confirm an already confirmed withdrawal? Not clear to me how to reproduce this. | |
| Initiate a withdrawal from the bank account and save the QR code somewhere. With your android wallet scan the QR code and complete the withdrawal. Then scan the QR code again, the wallet does not detect that the withdrawal is already confirmed and propose to confirm it again leading to the error. | |
| Shouldn't `getWithdrawalDetailsForUri` do the error reporting? | |
| What are the statuses where we can safely confirm the withdrawal? export type WithdrawalOperationStatusFlag = | "pending" | "selected" | "aborted" | "confirmed"; | |
| Not yet familiar enough with the codebase to fix this issue myself but I added some FIXME 0009683 in withdrawal tests where the current behavior should be improved | |
| I think that GetWithdrawalDetailsForUri does not check the database and that it is only checked when PrepareBankIntegratedWithdrawal is called after user interaction | |
| The code is also now using `prepareBankIntegratedWithdrawal` instead of `getWithdrawalAmountForUri`. commit f08622718ad42b2ae568d0242db55d220d26123d Author: Iván Ávalos <avalos@disroot.org> Date: Tue Apr 15 17:31:11 2025 +0200 [wallet] check B-I-W status after scanning URI bug 0009683 image.png (50,863 bytes) | |
| Just for reference: status = if (tx.txState.major == TransactionMajorState.Dialog) { InfoReceived } else { AlreadyConfirmed }, | |
- Anonymous