View Issue Details

IDProjectCategoryView StatusLast Update
0009680Talerwallet (Android App)public2025-05-10 02:11
ReporterChristian Grothoff Assigned Toavalos Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeveritytextReproducibilityN/A
Status closedResolutionfixed 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Product Versiongit (master) 
Target Version1.0Fixed in Version1.0 
Summary0009680: strange message: "payment initiated"
DescriptionI used the Android wallet to pay an order from a browser (QR code, to merchant backend). After clicking on confirm, the wallet shows the message "payment initiated", while the payment is clearly already done. The message should MAYBE be "payment initiated" while the REST call is ongoing, but after the HTTP call completed successfully the message MUST be changed to "payment completed".
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

avalos

2025-04-01 16:03

developer   ~0024362

The message is shown on a toast, which in Android is short-lived and only used to show quick alerts to the user, once it's shown the text can't really be changed. What I can do is render the “done” state for all transactions, so that an explicit confirmation is shown in screen that the transaction was successfully completed, like in the attached screenshot.
Screenshot_20250401-180219.png (120,051 bytes)   
Screenshot_20250401-180219.png (120,051 bytes)   

Christian Grothoff

2025-04-01 16:59

manager   ~0024363

Can you ensure to hide the toast once the payment is finished? Or maybe not even show the toast unless the payment didn't complete within say 100 ms?

What does iOS do? Are both platforms behaving the same way here?

avalos

2025-04-01 17:31

developer   ~0024365

> Can you ensure to hide the toast once the payment is finished?

No, the toast duration is defined by Android, I can't stop it once I fire it.

> Or maybe not even show the toast unless the payment didn't complete within say 100 ms?

I don't want to spun a thread just to count 100 ms, how about simply not showing the toast at all?

Christian Grothoff

2025-04-02 06:45

manager   ~0024372

Again: what does iOS do?

MarcS

2025-04-02 07:51

developer   ~0024374

The right thing™
See Mattermost wallet UI.

MarcS

2025-04-02 08:02

developer   ~0024375

after tapping "Pay 0,51 ク now", it slides to the "Loading" view, which dissolves to the final "Paid" view immediately when wallet-core signals the payment is done

Christian Grothoff

2025-04-02 08:04

manager   ~0024376

So no snack-bar, but a brief 'paying' dialog and then a transition to paid. Looks reasonable. @ivan: can you do something similar on Android?

avalos

2025-04-04 14:23

developer   ~0024401

The loading indicator was already there, I just removed the toast and now the "completed" status is explicitly shown on screen for all transactions, as you can see in the screenshot. :)

commit c3fd3a371d9cc83ad9a5fc4cf8e87ee8ead42d9e
Author: Iván Ávalos <avalos@disroot.org>
Date: Fri Apr 4 14:11:27 2025 +0200

    [wallet] remove "Payment initiated" toast
image.png (65,054 bytes)   
image.png (65,054 bytes)   

Issue History

Date ModifiedUsernameFieldChange
2025-03-30 15:56Christian GrothoffNew Issue
2025-03-30 15:56Christian GrothoffStatusnew => assigned
2025-03-30 15:56Christian GrothoffAssigned To => avalos
2025-04-01 16:03avalosNote Added: 0024362
2025-04-01 16:03avalosFile Added: Screenshot_20250401-180219.png
2025-04-01 16:04avalosAssigned Toavalos => Christian Grothoff
2025-04-01 16:04avalosStatusassigned => feedback
2025-04-01 16:59Christian GrothoffNote Added: 0024363
2025-04-01 16:59Christian GrothoffAssigned ToChristian Grothoff => avalos
2025-04-01 17:31avalosNote Added: 0024365
2025-04-01 17:31avalosAssigned Toavalos => Christian Grothoff
2025-04-01 17:31avalosStatusfeedback => new
2025-04-01 17:31avalosStatusnew => feedback
2025-04-02 06:45Christian GrothoffNote Added: 0024372
2025-04-02 06:46Christian GrothoffAssigned ToChristian Grothoff => MarcS
2025-04-02 07:51MarcSNote Added: 0024374
2025-04-02 07:51MarcSAssigned ToMarcS => Christian Grothoff
2025-04-02 08:02MarcSNote Added: 0024375
2025-04-02 08:02MarcSFile Added: Screenshot 2025-04-02 at 09.58.11.png
2025-04-02 08:04Christian GrothoffNote Added: 0024376
2025-04-02 08:04Christian GrothoffAssigned ToChristian Grothoff => avalos
2025-04-02 08:04Christian GrothoffStatusfeedback => assigned
2025-04-04 14:23avalosNote Added: 0024401
2025-04-04 14:23avalosFile Added: image.png
2025-04-04 14:24avalosStatusassigned => informing
2025-04-04 14:24avalosResolutionopen => fixed
2025-04-06 08:26Christian GrothoffFixed in Version => 1.0
2025-04-06 08:26Christian GrothoffTarget Version1.0 stretch goals => 1.0
2025-05-10 02:11Christian GrothoffStatusinforming => closed