View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0009631 | Taler | merchant backend | public | 2025-03-18 12:37 | 2025-05-10 02:11 |
| Reporter | fefe | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 1.0 | Fixed in Version | 1.0 | ||
| Summary | 0009631: enum type mismatch in parse_abort | ||||
| Description | In taler-merchant-httpd_post-orders-ID-abort.c: 896 return TALER_MHD_reply_with_error (connection, This is nitpicking, but TALER_MHD_reply_with_error returns an MHD_Result, but parse_abort returns a GNUNET_GenericReturnValue. MHD_Result defines 0 and 1, which are defined with the same meaning in GNUNET_GenericReturnValue. The cast is also technically OK because you can cast enum to int and vice versa. I would still recommend making it an explicit cast. | ||||
| Tags | No tags attached. | ||||
| Was actually worse than this, because MHD_YES (1) needs to be mapped to GNUNET_NO (0) for error returned and MHD_NO (0) to GNUNET_SYSERR (-1) for failed to return error. Fixed in db5b27048897329157cbec8fdf3ee2482cfca161 | |
| Fix committed to master branch. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2025-03-18 12:37 | fefe | New Issue | |
| 2025-03-18 12:37 | fefe | Status | new => assigned |
| 2025-03-18 12:37 | fefe | Assigned To | => Christian Grothoff |
| 2025-03-19 00:46 | Christian Grothoff | Note Added: 0024235 | |
| 2025-03-19 00:46 | Christian Grothoff | Status | assigned => informing |
| 2025-03-19 00:46 | Christian Grothoff | Resolution | open => fixed |
| 2025-03-19 00:46 | Christian Grothoff | Fixed in Version | => 1.0 |
| 2025-03-19 00:46 | Christian Grothoff | Product Version | => git (master) |
| 2025-03-19 00:46 | Christian Grothoff | Target Version | => 1.0 |
| 2025-03-19 00:47 | Christian Grothoff | ||
| 2025-03-19 00:47 | Christian Grothoff | Note Added: 0024236 | |
| 2025-03-22 13:09 | Christian Grothoff | Category | mechant backend => merchant backend |
| 2025-05-10 02:11 | Christian Grothoff | Status | informing => closed |