View Issue Details

IDProjectCategoryView StatusLast Update
0009593Talerwallet-corepublic2026-09-19 14:45
ReporterFlorian Dold Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status informingResolutionfixed 
Target Version1.6Fixed in Version1.6 
Summary0009593: Revisit lazy denomination validation logic [1-2d]
Description* There should be an async task for lazy validation
* It should be clear from the DB state of the exchange if lazy validation is up-to-date or not
Tagsperformance

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

child of 0008248 implementing get wallet-core codebase ready for code review [60+h] 

Activities

Florian Dold

2025-03-04 19:26

manager   ~0024159

Probably the easiest way to address this is to:
* make the denom validation part of the exchange update task, consider exchange entries with unvalidated candidate withdrawal denoms outdated
* consistently require updated exchange entries in places where we currently don't (e.g. starting a p2p debit), as the update exchange entry is needed to properly compute fees (refresh requires up-to-date denom validation)

Florian Dold

2025-03-04 19:46

manager   ~0024160

The exchange entry should have some field with a timestamp for the earliest un-validated denomination to make the check in the update routine cheap.

Christian Grothoff

2025-03-18 10:15

manager   ~0024207

Why is this critical for 1.0?

Florian Dold

2025-03-26 13:28

manager   ~0024310

Not exactly launch-critical for 1.0, but something I wanted to address before the audit of wallet-core begins.

Florian Dold

2026-08-27 07:53

manager   ~0029636

Denomination validation is integrated into exchange updating/readiness and current callers fetch fresh exchange data before coin use.

Issue History

Date ModifiedUsernameFieldChange
2025-03-04 19:11Florian DoldNew Issue
2025-03-04 19:11Florian DoldStatusnew => assigned
2025-03-04 19:11Florian DoldAssigned To => Florian Dold
2025-03-04 19:26Florian DoldNote Added: 0024159
2025-03-04 19:46Florian DoldNote Added: 0024160
2025-03-18 10:15Christian GrothoffNote Added: 0024207
2025-03-21 13:33Florian DoldSummaryRevisit lazy denomination validation logic => Revisit lazy denomination validation logic [1-2d]
2025-03-26 13:28Florian DoldNote Added: 0024310
2025-04-17 22:27Christian GrothoffTag Attached: optimization
2025-04-17 22:27Christian GrothoffAssigned ToFlorian Dold =>
2025-04-17 22:27Christian GrothoffStatusassigned => implementing
2025-04-18 13:23Christian GrothoffRelationship addedchild of 0008248
2025-04-18 13:23Christian GrothoffTarget Version1.0 => post-1.0
2026-01-25 14:15Christian GrothoffTag Detached: optimization
2026-01-25 14:18Christian GrothoffTag Attached: performance
2026-08-27 07:53Florian DoldAssigned To => Florian Dold
2026-08-27 07:53Florian DoldStatusimplementing => informing
2026-08-27 07:53Florian DoldResolutionopen => fixed
2026-08-27 07:53Florian DoldNote Added: 0029636
2026-09-19 14:40Christian GrothoffFixed in Version => 1.6
2026-09-19 14:45Christian GrothoffTarget Versionpost-1.0 => 1.6