View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0009593 | Taler | wallet-core | public | 2025-03-04 19:11 | 2026-09-19 14:45 |
| Reporter | Florian Dold | Assigned To | Florian Dold | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | informing | Resolution | fixed | ||
| Target Version | 1.6 | Fixed in Version | 1.6 | ||
| Summary | 0009593: Revisit lazy denomination validation logic [1-2d] | ||||
| Description | * There should be an async task for lazy validation * It should be clear from the DB state of the exchange if lazy validation is up-to-date or not | ||||
| Tags | performance | ||||
| child of | 0008248 | implementing | get wallet-core codebase ready for code review [60+h] |
| Probably the easiest way to address this is to: * make the denom validation part of the exchange update task, consider exchange entries with unvalidated candidate withdrawal denoms outdated * consistently require updated exchange entries in places where we currently don't (e.g. starting a p2p debit), as the update exchange entry is needed to properly compute fees (refresh requires up-to-date denom validation) | |
| The exchange entry should have some field with a timestamp for the earliest un-validated denomination to make the check in the update routine cheap. | |
| Why is this critical for 1.0? | |
| Not exactly launch-critical for 1.0, but something I wanted to address before the audit of wallet-core begins. | |
| Denomination validation is integrated into exchange updating/readiness and current callers fetch fresh exchange data before coin use. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2025-03-04 19:11 | Florian Dold | New Issue | |
| 2025-03-04 19:11 | Florian Dold | Status | new => assigned |
| 2025-03-04 19:11 | Florian Dold | Assigned To | => Florian Dold |
| 2025-03-04 19:26 | Florian Dold | Note Added: 0024159 | |
| 2025-03-04 19:46 | Florian Dold | Note Added: 0024160 | |
| 2025-03-18 10:15 | Christian Grothoff | Note Added: 0024207 | |
| 2025-03-21 13:33 | Florian Dold | Summary | Revisit lazy denomination validation logic => Revisit lazy denomination validation logic [1-2d] |
| 2025-03-26 13:28 | Florian Dold | Note Added: 0024310 | |
| 2025-04-17 22:27 | Christian Grothoff | Tag Attached: optimization | |
| 2025-04-17 22:27 | Christian Grothoff | Assigned To | Florian Dold => |
| 2025-04-17 22:27 | Christian Grothoff | Status | assigned => implementing |
| 2025-04-18 13:23 | Christian Grothoff | Relationship added | child of 0008248 |
| 2025-04-18 13:23 | Christian Grothoff | Target Version | 1.0 => post-1.0 |
| 2026-01-25 14:15 | Christian Grothoff | Tag Detached: optimization | |
| 2026-01-25 14:18 | Christian Grothoff | Tag Attached: performance | |
| 2026-08-27 07:53 | Florian Dold | Assigned To | => Florian Dold |
| 2026-08-27 07:53 | Florian Dold | Status | implementing => informing |
| 2026-08-27 07:53 | Florian Dold | Resolution | open => fixed |
| 2026-08-27 07:53 | Florian Dold | Note Added: 0029636 | |
| 2026-09-19 14:40 | Christian Grothoff | Fixed in Version | => 1.6 |
| 2026-09-19 14:45 | Christian Grothoff | Target Version | post-1.0 => 1.6 |