View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0009527 | Taler | merchant backend | public | 2025-02-10 13:16 | 2025-05-10 02:11 |
| Reporter | fefe | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | 0.14 | ||||
| Target Version | 1.0 | Fixed in Version | 1.0 | ||
| Summary | 0009527: FIXME in TALER_MERCHANTDB_category_details_free looks like a legit memory leak | ||||
| Description | This is in exchange/src/merchantdb/merchantdb_helper.c: ``` 85 void 86 TALER_MERCHANTDB_category_details_free ( 87 struct TALER_MERCHANTDB_CategoryDetails *cd) 88 { 89 GNUNET_free (cd->category_name); 90 json_decref (cd->category_name_i18n); 91 // FIXME: also return product details 92 // for (unsigned int i = 0; i<cd->num_products; i++) 93 // { 94 // const char* *ps 95 // = &cd->products[i]; 96 97 // GNUNET_free (ps); 98 // // GNUNET_free (ps->description); 99 // // json_decref (ps->description_i18n); 100 // } 101 // GNUNET_array_grow (cd->products, 102 // cd->num_products, 103 // 0); 104 } ``` The FIXME looks right. The struct has more members that this function isn't freeing right now. Is this a memory leak? | ||||
| Tags | No tags attached. | ||||
| You're on an outdated code base, this was already fixed in Git master (with various other cleanups and FIXMEs). Can you maybe shift to auditing 0.14.5? | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2025-02-10 13:16 | fefe | New Issue | |
| 2025-02-10 13:16 | fefe | Status | new => assigned |
| 2025-02-10 13:16 | fefe | Assigned To | => Christian Grothoff |
| 2025-02-10 13:40 | Christian Grothoff | Note Added: 0024061 | |
| 2025-02-10 13:40 | Christian Grothoff | Status | assigned => informing |
| 2025-02-10 13:40 | Christian Grothoff | Resolution | open => fixed |
| 2025-02-10 13:40 | Christian Grothoff | Fixed in Version | => 1.0 |
| 2025-02-10 13:40 | Christian Grothoff | Product Version | => 0.14 |
| 2025-02-10 13:40 | Christian Grothoff | Target Version | => 1.0 |
| 2025-03-22 13:09 | Christian Grothoff | Category | mechant backend => merchant backend |
| 2025-05-10 02:11 | Christian Grothoff | Status | informing => closed |