| Locale-dependent amount rendering is currently used in all amount inputs, so the placement of the currency symbol can be either left or right. Furthermore, some views require a currency selector. If the currency has no symbol or the symbol is the same as the currency string, the same string will appear in both the amount input and the currency selector. [ NETZBON 1.0 ] [ NETZBON ▾ ] [ NETZBON ] [ KUDOS ] [ CHF ] [ EUR ] | |
| Well, I understand amount-rending is locale dependent and that we sometimes need a currency selector. But, what is probably bad is to (1) have the currency be stated twice, and (2) run out of space because of it, causing Isidor trouble reading the amount next to the currency due to lack of whitespace. My suggestion: put the currency selector either to the right or to the left of the actual amount, depending on the locale. Do NOT put the currency into the amount editing widget as well, thus: [NEZTBON ▾ ] 1.0 or 1.0 [NEZTBON ▾ ] depending on locale (with 1.0 being the editable number). Sounds good? | |
| MarcS: what does iOS do? | |
| > My suggestion: put the currency selector either to the right or to the left of the actual amount, depending on the locale. AFAIK, I don't get that information from the locale, I only get the final formatted string. I can do a test formatting and find the positioning manually, but I don't like it :\ I will remove the symbol from the input, but can we just leave it on the right? Besides, the selector contains the currency string (e.g. KUDOS), not the symbol (e.g. ク), so semantically speaking it isn't really meant to be part of the formatted amount, so locale-dependent formatting does not apply. | |
| I see. I think the problem is different: for NETZBON, the symbol is the SAME as the currency string, which is probably also why it looks particularly bad. If it is just ク3.45 or 4.5$ it wouldn't be a problem, but putting NETZBON twice in the same line is bad. So maybe there is an alternative: keep the existing logic, but *if* the symbol and the currency string are *identical*, give an empty string for the symbol to the currency formatter in this specific dialog where the currency string is shown in a box on the right. Marc: WDYT? | |
| > *if* the symbol and the currency string are *identical*, give an empty string for the symbol to the currency formatter in this specific dialog where the currency string is shown in a box on the right. ACK, sounds good... | |
| Yep, sounds good. :) | |
| Fixed in master! :) commit c9a7c750322c3d4957f05ba6b286681398eb7e48 Author: Iván Ávalos <avalos@disroot.org> Date: Thu Feb 6 15:56:56 2025 +0100 [wallet] hide symbol from amount input if it matches currency string bug 0009494 image.png (63,138 bytes) | |
- Anonymous