View Issue Details

IDProjectCategoryView StatusLast Update
0009458Talermerchant backendpublic2025-05-10 02:11
Reporterfefe Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version1.0Fixed in Version1.0 
Summary0009458: sign_token_envelopes: off by one?
Description```
2566 const struct TokenEnvelope *env = &pc->token_envelopes[pos];
2567 struct SignedOutputToken *output = &pc->output_tokens[pos];
2568
2569 if (pos > pc->token_envelopes_cnt || pos > pc->output_tokens_len)
2570 {
2571 GNUNET_assert (0); /* this should not happen */
2572 return GNUNET_NO;
2573 }
```

Isn't pos already out of bounds if it is == the count?
If the count is 3 then the valid indices are 0, 1, 2 ...?
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2025-01-14 15:18

manager   ~0023977

Fix committed to master branch.

Christian Grothoff

2025-01-14 15:18

manager   ~0023978

Indeed. Fixed in 34f8e020..9c5b4f1d

Issue History

Date ModifiedUsernameFieldChange
2025-01-14 14:35fefeNew Issue
2025-01-14 14:35fefeStatusnew => assigned
2025-01-14 14:35fefeAssigned To => Christian Grothoff
2025-01-14 15:18Christian Grothoff
2025-01-14 15:18Christian GrothoffNote Added: 0023977
2025-01-14 15:18Christian GrothoffStatusassigned => informing
2025-01-14 15:18Christian GrothoffResolutionopen => fixed
2025-01-14 15:18Christian GrothoffFixed in Version => 1.0
2025-01-14 15:18Christian GrothoffNote Added: 0023978
2025-03-22 13:09Christian GrothoffCategorymechant backend => merchant backend
2025-03-28 12:12Christian GrothoffTarget Version => 1.0
2025-05-10 02:11Christian GrothoffStatusinforming => closed