View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0009422 | Taler | exchange | public | 2024-12-28 14:06 | 2026-10-13 09:05 |
| Reporter | Christian Grothoff | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | N/A |
| Status | informing | Resolution | fixed | ||
| Platform | i7 | OS | Debian GNU/Linux | OS Version | squeeze |
| Product Version | git (master) | ||||
| Target Version | 1.6 | Fixed in Version | 1.6 | ||
| Summary | 0009422: TALER_EXCHANGE_check_coin_conflict_ was never implemented | ||||
| Description | This is to check client-side that coins were actually in conflict (say different denoms or different age commitments). | ||||
| Tags | No tags attached. | ||||
| Also, TALER_EXCHANGE_check_coin_denomination_conflict_ should actually be *used*. | |
| Fixed with commit 13bdc0e3419a27d8d9b1fef915b8c91b765e257f in dev/oec/vCONFLICT: lib: verify the coin conflict proofs of 409 responses Following the vCONFLICT spec, the denomination conflict reply now carries the stored age commitment hash and the age commitment conflict reply the stored denomination signature, so both can be verified with the coin data alone. The client library parses these replies into struct TALER_EXCHANGE_CoinConflict and checks them in TALER_EXCHANGE_check_coin_conflict_(): the denomination resp. age commitment named by the exchange must differ from what the client used, and the exchange's signature must verify against the denomination from /keys. If that denomination is not in /keys, the reply is accepted as unverifiable (verified=false). Batch deposit, melt, purse create, purse deposit, reserve open and both recoup clients run the check and expose the details in their results; a failed check yields TALER_EC_GENERIC_REPLY_MALFORMED. The details are released only for a 409 with one of the two error codes, as they share a union with the details of other replies. The unimplemented stub and the unused helpers are removed. The JSON parsers for denomination public keys now fill pub_key_hash, so parsed keys compare equal to locally created ones. | |
| Please check the fix in the commit mentioned before. | |
| conflict detection function looks good, vCONFLICT branch was merged. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-12-28 14:06 | Christian Grothoff | New Issue | |
| 2024-12-28 14:06 | Christian Grothoff | Status | new => assigned |
| 2024-12-28 14:06 | Christian Grothoff | Assigned To | => oec |
| 2024-12-28 14:17 | Christian Grothoff | Note Added: 0023919 | |
| 2025-12-07 09:54 | Christian Grothoff | Status | assigned => implementing |
| 2026-09-24 12:33 | oec | Status | implementing => informing |
| 2026-09-24 12:33 | oec | Resolution | open => fixed |
| 2026-09-24 12:33 | oec | Note Added: 0030034 | |
| 2026-09-24 14:10 | Christian Grothoff | Assigned To | oec => Christian Grothoff |
| 2026-09-24 14:10 | Christian Grothoff | Status | informing => assigned |
| 2026-09-24 14:10 | Christian Grothoff | Target Version | post-1.0 => 1.7 |
| 2026-09-24 15:08 | oec | Status | assigned => feedback |
| 2026-09-24 15:08 | oec | Note Added: 0030040 | |
| 2026-10-09 19:14 | Christian Grothoff | Status | feedback => informing |
| 2026-10-09 19:14 | Christian Grothoff | Fixed in Version | => 1.7 |
| 2026-10-09 19:14 | Christian Grothoff | Note Added: 0030093 | |
| 2026-10-13 09:05 | Christian Grothoff | Fixed in Version | 1.7 => 1.6 |
| 2026-10-13 09:05 | Christian Grothoff | Target Version | 1.7 => 1.6 |