View Issue Details

IDProjectCategoryView StatusLast Update
0009367Talerwallet-corepublic2025-05-10 02:11
ReporterFlorian Dold Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version1.0Fixed in Version1.0 
Summary0009367: add flag to balance-change notification for transaction that change the user-visible balance
DescriptionWe use the notifications for various purposes, telling the UI that the user-visible balance changed is just one of them.

To prevent unnecessary UI updates, the notification should have an extra flag to indicate if a user-visible balance was affected.

The notification will still be emitted when the material balance changes (not directly visible to the user!), but the flag won't be set.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Florian Dold

2025-01-07 15:07

manager   ~0023942

We still emit non-internal balance change notifications for refresh:

{"type":"notification","payload":{"type":"balance-change","hintTransactionId":"txn:refresh:TMK2AN1MZQF5TCBZG0R7NJ50DYY9XDDKB7TVRX8DV2FJQM6M1M70","isInternal":false}}

We should only do that if refresh fails.

Florian Dold

2025-01-10 11:18

manager   ~0023966

commit ed409e0d56e913c8a999aa5e92afc4e6b15c570e
Author: Florian Dold <florian@dold.me>
Date: Thu Jan 9 17:52:16 2025 +0100

    wallet-core: add better tracking of balance change effects
    
    We now keep track whether a transaction transition (a) doesn't change
    the balance, (b) changes the balance, but preserves the user-visible
    balance or (c) can also change the user-visible balance.

Issue History

Date ModifiedUsernameFieldChange
2024-12-04 11:02Florian DoldNew Issue
2024-12-04 11:02Florian DoldStatusnew => assigned
2024-12-04 11:02Florian DoldAssigned To => Florian Dold
2025-01-07 15:07Florian DoldNote Added: 0023942
2025-01-10 11:18Florian DoldStatusassigned => informing
2025-01-10 11:18Florian DoldResolutionopen => fixed
2025-01-10 11:18Florian DoldNote Added: 0023966
2025-02-14 21:42Christian GrothoffFixed in Version => 1.0
2025-05-10 02:11Christian GrothoffStatusinforming => closed