View Issue Details

IDProjectCategoryView StatusLast Update
0009360Talermerchant backendpublic2025-12-21 20:46
ReporterFlorian Dold Assigned Tosebasjm Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeveritytweakReproducibilityhave not tried
Status closedResolutionfixed 
Target Version1.3Fixed in Version1.3 
Summary0009360: consider computing refund deadline based on payment deadline, not order creation timestamp
DescriptionThat way we guarantee that the user always has at least the time span defined by `refund_delay` to ask for a refund.

(Suggested during QC, rationale is that the user might pay minutes after scanning the QR code, and when the refund deadline would have already expired.)
Tagsux

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

related to 0009078 closedsebasjm Default wire transfer delay should be absolute 

Activities

Christian Grothoff

2025-10-28 19:35

manager   ~0026271

Semantics will change to be cumulative for all delays, so pay_delay on top of order creation, refund_delay on top of payment deadline, wire_transfer_delay on top of the refund deadline, and then (see 0009078) the final wire transfer deadline may be subject to rounding up based on a default_wire_rounding_interval. (as of v23).

Christian Grothoff

2025-10-28 21:59

manager   ~0026272

c2fdcad95404316a673c4fcd5d8ab0f1af7dffbc .. d79af27618a095b7f48f1d5b359dd5f80559e238 implement the new cumulative delay logic.
This still requires changes to the wallet-core testsuite, hence assigning now to Florian.

Florian Dold

2025-11-14 19:36

manager   ~0026443

The tests have been adjusted.

Is there anything else to do? UI / documentation?

Christian Grothoff

2025-11-28 21:23

manager   ~0026674

The refund_delay now can be any value, and is no longer constrained by the wire_delay or pay_delay, as they are each additive.
So Sebastian: please remove the corresponding constraints from the merchant SPA.

sebasjm

2025-12-12 12:02

developer   ~0026936

d3a94fe62

Issue History

Date ModifiedUsernameFieldChange
2024-11-27 15:14Florian DoldNew Issue
2024-11-27 15:14Florian DoldStatusnew => assigned
2024-11-27 15:14Florian DoldAssigned To => Christian Grothoff
2024-11-28 23:02Christian GrothoffAssigned ToChristian Grothoff =>
2024-11-28 23:02Christian GrothoffStatusassigned => implementing
2024-12-07 22:04Christian GrothoffTarget Versionpost-1.0 => 1.5
2024-12-07 22:05Christian GrothoffRelationship addedrelated to 0009078
2025-01-02 12:01Christian GrothoffSeverityminor => tweak
2025-03-22 13:09Christian GrothoffCategorymechant backend => merchant backend
2025-04-17 20:45Christian GrothoffTag Attached: ux
2025-10-22 19:41Christian GrothoffAssigned To => Christian Grothoff
2025-10-22 19:41Christian GrothoffStatusimplementing => assigned
2025-10-28 19:35Christian GrothoffNote Added: 0026271
2025-10-28 21:59Christian GrothoffNote Added: 0026272
2025-10-28 21:59Christian GrothoffAssigned ToChristian Grothoff => Florian Dold
2025-11-14 19:36Florian DoldAssigned ToFlorian Dold =>
2025-11-14 19:36Florian DoldStatusassigned => feedback
2025-11-14 19:36Florian DoldNote Added: 0026443
2025-11-28 21:23Christian GrothoffNote Added: 0026674
2025-11-28 21:23Christian GrothoffAssigned To => sebasjm
2025-11-28 21:23Christian GrothoffStatusfeedback => assigned
2025-12-12 12:02sebasjmStatusassigned => informing
2025-12-12 12:02sebasjmResolutionopen => fixed
2025-12-12 12:02sebasjmNote Added: 0026936
2025-12-15 10:45Christian GrothoffTarget Version1.5 => 1.3
2025-12-15 10:46Christian GrothoffFixed in Version => 1.3
2025-12-21 20:46Christian GrothoffStatusinforming => closed