View Issue Details

IDProjectCategoryView StatusLast Update
0009334Talerwallet-corepublic2026-03-20 23:55
ReporterFlorian Dold Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version1.5Fixed in Version1.5 
Summary0009334: wallet does not automatically handle expired pay-merchant transactions, payment-expired test also only handles manual case [6h]
DescriptionTest needs to be fixed to cover both cases, wallet-core needs to handle expiration automatically.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

The plan

IDSummaryStatusAssigned ToEstimated effort (hours)
0010066expired peer-pull-credit transaction not transitioning to final state [2h] closedFlorian Dold
This issue (hours)
Its children (hours)0
Together (hours)0
Nothing is missing: the plan can be finished.

Relationships

parent of 0010066 closedFlorian Dold expired peer-pull-credit transaction not transitioning to final state [2h] 

Activities

Florian Dold

2024-11-12 12:30

manager   ~0023705

The wallet needs to handle both cases:
* it sees from the timestamp that the order is expired (=> does not even attempt to pay)
* the merchant claims that the order is expired (=> refresh)

Both cases need to be handled in case the payment request takes long (causing us to hit the deadline) or there is clock shift.

Florian Dold

2024-11-19 14:22

manager   ~0023735

Implemented, just needs some testing with the UIs.

Florian Dold

2025-05-26 08:47

manager   ~0025000

Actually, still missing the automatic transition to expired without having to do confirmPay.

Florian Dold

2026-03-12 12:21

manager   ~0028117

Last edited: 2026-03-19 22:44

Additional requirement requested by Marc: we should consider deleting expired transaction 24h after they've expired.

Florian Dold

2026-03-19 22:53

manager   ~0028190

commit b7b77db25f33bd675f3ee721376052dd1710b509 (HEAD -> master, origin/master, origin/HEAD)
Author: Florian Dold <florian@dold.me>
Date: Thu Mar 19 23:53:10 2026 +0100

    wallet-core: automatically delete expired pay-merchant transactions after 24h

commit e540862ac5ecf5b55ae9129f1b61e7ee01894f2f
Author: Florian Dold <florian@dold.me>
Date: Thu Mar 19 23:41:17 2026 +0100

    wallet-core: automatically expire pay-merchant transactions

Florian Dold

2026-03-19 22:54

manager   ~0028191

Just needs a test now.

Florian Dold

2026-03-19 23:00

manager   ~0028193

commit 574d6ece737fc0722e0960f133f98c2dd294baa6 (HEAD -> master, origin/master, origin/HEAD)
Author: Florian Dold <florian@dold.me>
Date: Fri Mar 20 00:00:20 2026 +0100

    harness: test for expired pay transactions in dialog state

Issue History

Date ModifiedUsernameFieldChange
2024-11-12 12:27Florian DoldNew Issue
2024-11-12 12:27Florian DoldStatusnew => assigned
2024-11-12 12:27Florian DoldAssigned To => Florian Dold
2024-11-12 12:30Florian DoldNote Added: 0023705
2024-11-19 14:22Florian DoldNote Added: 0023735
2024-12-04 21:54Florian DoldAssigned ToFlorian Dold => MarcS
2024-12-16 20:23Christian GrothoffTarget Version0.14 => 1.0
2025-04-18 13:28Christian GrothoffTarget Version1.0 => 1.0 stretch goals
2025-05-26 08:46Florian DoldAssigned ToMarcS => Florian Dold
2025-05-26 08:47Florian DoldNote Added: 0025000
2025-06-04 23:55Florian DoldTarget Version1.0 stretch goals => 1.6
2025-06-05 12:06Florian DoldSummarywallet does not automatically handle expired pay-merchant transactions, payment-expired test also only handles manual case => wallet does not automatically handle expired pay-merchant transactions, payment-expired test also only handles manual case [6h]
2025-08-31 17:35Christian GrothoffRelationship addedparent of 0010066
2025-09-04 18:44Christian GrothoffTarget Version1.6 => 1.5
2026-03-12 12:21Florian DoldNote Added: 0028117
2026-03-19 22:44Florian DoldNote Edited: 0028117
2026-03-19 22:53Florian DoldNote Added: 0028190
2026-03-19 22:54Florian DoldNote Added: 0028191
2026-03-19 23:00Florian DoldNote Added: 0028193
2026-03-19 23:01Florian DoldStatusassigned => informing
2026-03-19 23:01Florian DoldResolutionopen => fixed
2026-03-20 23:47Christian GrothoffFixed in Version => 1.5
2026-03-20 23:55Christian GrothoffStatusinforming => closed