View Issue Details

IDProjectCategoryView StatusLast Update
0009332Talerwallet-corepublic2024-12-13 18:15
ReporterMarcS Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version0.14 
Target Version0.14Fixed in Version0.14 
Summary0009332: wallet-core should NOT post balance-change when balance (or pending) didn't change
DescriptionAfter scanning e.g. a pay-talerURI, wallet-core immediately posts a transaction-state-transition (OK), followed by a 'balance-change' notification (not OK, because the user didn't yet confirm the payment, thus the balance didn't change, yet).
This leads to unnecessary view updates which cause flicker.

==> only post balance-change *after* coins were added to or removed from the DB - or after pendingIncoming / pendingOutgoing changed. The wallet will immediately call getBalances and re-render all views...
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Florian Dold

2024-12-04 21:53

manager   ~0023789

We now have an `isInternal` flag, which will (usually!) be set to true when the balance change doesn't affect the user-visible balance.

We are not completely removing the internal balance change notification, as wallet-core needs them internally, and we might need them for testing.

Not all internal balances changes are marked as such yet, we should address those on a case-by-case basis.

Issue History

Date ModifiedUsernameFieldChange
2024-11-09 16:51MarcSNew Issue
2024-11-09 16:51MarcSStatusnew => assigned
2024-11-09 16:51MarcSAssigned To => Florian Dold
2024-12-04 21:53Florian DoldStatusassigned => informing
2024-12-04 21:53Florian DoldResolutionopen => fixed
2024-12-04 21:53Florian DoldNote Added: 0023789
2024-12-13 00:59Christian GrothoffFixed in Version => 0.14
2024-12-13 01:00Christian GrothoffTarget Version => 0.14
2024-12-13 18:15Christian GrothoffStatusinforming => closed