View Issue Details

IDProjectCategoryView StatusLast Update
0009312GNUnetutil librarypublic2024-12-09 17:03
Reporterfefe Assigned Toschanzen Due Date
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.23.0Fixed in Version0.23.0 
Summary0009312: GNUNET_DISK_internal_file_handle_: why void*?!
DescriptionHere is the prototype of the function:

  1631 enum GNUNET_GenericReturnValue
  1632 GNUNET_DISK_internal_file_handle_ (const struct GNUNET_DISK_FileHandle *fh,
  1633 void *dst,
  1634 size_t dst_len)

why would you have void*?!
You are writing an int. Always. So make it an int* and get rid of the dst_len.
You are subverting the type system and also you are introducing alignment issues on platforms that have SIGBUS for unaligned memory accesses. void* has no alignment requirements but int* does.
TagsNo tags attached.

Activities

schanzen

2024-12-09 17:03

administrator   ~0023829

Released

Issue History

Date ModifiedUsernameFieldChange
2024-11-01 15:01fefeNew Issue
2024-11-03 19:34schanzenTarget Version => 0.22.3
2024-11-03 19:43schanzenAssigned To => schanzen
2024-11-03 19:43schanzenStatusnew => resolved
2024-11-03 19:43schanzenResolutionopen => fixed
2024-11-14 08:43schanzenTarget Version0.22.3 => 0.23.0
2024-12-09 17:03schanzenFixed in Version => 0.23.0
2024-12-09 17:03schanzenNote Added: 0023829
2024-12-09 17:03schanzenStatusresolved => closed