View Issue Details

IDProjectCategoryView StatusLast Update
0009308GNUnetutil librarypublic2024-12-09 17:03
Reporterfefe Assigned ToChristian Grothoff Due Date
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.23.0Fixed in Version0.23.0 
Summary0009308: GNUNET_DISK_file_read_non_blocking: function makes no sense
DescriptionThe function sets the O_NONBLOCK flag on a descriptor, does a read, and then un-sets the flag again.
The functiojn name explicitly says DISK. That flag does not apply to disk files.

It does apply to pipes and sockets however, and for those doing what the function does may be harmful, because that flag applies to the underlying pipe object in the kernel, not just to the descriptor. See https://cr.yp.to/unix/nonblock.html for a list of the problems.

Why do you even have this function?
TagsNo tags attached.

Activities

schanzen

2024-11-03 20:02

administrator   ~0023644

It is not used anywhere. I vote to remove/deprecate.

Christian Grothoff

2024-11-04 06:30

manager   ~0023647

I agree, let's remove it.

schanzen

2024-12-09 17:03

administrator   ~0023839

Released

Issue History

Date ModifiedUsernameFieldChange
2024-11-01 13:43fefeNew Issue
2024-11-03 19:34schanzenTarget Version => 0.22.3
2024-11-03 20:02schanzenNote Added: 0023644
2024-11-03 20:02schanzenAssigned To => Christian Grothoff
2024-11-03 20:02schanzenStatusnew => assigned
2024-11-04 06:30Christian GrothoffNote Added: 0023647
2024-11-04 06:33Christian GrothoffStatusassigned => resolved
2024-11-04 06:33Christian GrothoffResolutionopen => fixed
2024-11-04 06:33Christian GrothoffFixed in Version => 0.22.3
2024-11-14 08:43schanzenTarget Version0.22.3 => 0.23.0
2024-11-14 08:44schanzenFixed in Version0.22.3 =>
2024-12-09 17:03schanzenFixed in Version => 0.23.0
2024-12-09 17:03schanzenNote Added: 0023839
2024-12-09 17:03schanzenStatusresolved => closed