View Issue Details

IDProjectCategoryView StatusLast Update
0009264Talerwallet (WebExtension)public2024-12-13 18:15
ReporterStefan Assigned Tosebasjm Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeveritytweakReproducibilityalways
Status closedResolutionno change required 
Product Version0.13 
Target Version0.14Fixed in Version0.14 
Summary0009264: The pull payment request from a wallet should be handled in the WebEx wallet under the "Send" flow, and not under "Receive"
DescriptionI am using the WebEx wallet version 0.13.1 (the latest update, from August 30) and the latest Android-based wallet (0.13.2 c872041, nightly apk 1726832198). I create an invoice on the Android wallet (clicking on "Receive" --> typing in amount --> "Invoice another wallet"; next screen: typing in the subject, clicking on "Create invoice") and the next screen shows the generated QR code. All fine until here.

But when I have to show this QR code to the webextension wallet on my computer - to confirm this payment - I need to start this in the WebEx wallet by clicking on "Receive" (!), then choosing "From a taler:// URI or QR code" --> Enter URI here --> Use camera --> scan the QR code on the smartphone --> confirming the payment --> the request is processed.

It would make sense now to have the feature of paying to pull requests from other wallets also under "Send" and not "Receive". Users will expect this payment option there only, but surely not under "Receive".

Be sure that you have the feature still remaining under "Receive" for the influx of e-cash from wallets that are using the Taler URI or a QR code, though.


Secondly, I have a wording improvement: The English string "Invoice another wallet" (wallet/src/main/res/values-de/strings.xml, string 138) was until now corresponding with the German translation "Rechnung an anderes Wallet stellen". I shortened the string to "Rechnung erstellen", because it fits better onto the screen and still makes sense as it just deals with an invoice (to whomever or whatever).

I did the change in Weblate already. The result is that two keys are now identical in German ("Rechnung erstellen"):
https://weblate.taler.net/translate/gnu-taler/wallet-android/de/?sort_by=-priority%2Cposition&offset=138 ("Invoice another wallet", receive_peer)
and
https://weblate.taler.net/translate/gnu-taler/wallet-android/de/?sort_by=-priority%2Cposition&offset=139 ("Create invoice", receive_peer_create_button)

Are there any objections to do this change? Thank you for performing the tweak described above and for a shot feedback to my string change.

Cheers,
Stefan
TagsNo tags attached.
Attached Files

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

sebasjm

2024-10-28 16:33

developer   ~0023609

> But when I have to show this QR code to the webextension wallet on my computer - to confirm this payment - I need to start this in the WebEx wallet by clicking on "Receive" (!),

Why not just use the QR icon on the top right corner?

Adding this link is very easy but I find it redundant since you have the icon right there.

sebasjm

2024-10-28 16:34

developer   ~0023610

9bc63cf19..832cf23a9

Stefan

2024-10-28 18:50

reporter   ~0023611

Hi, Sebastian,
The webex users will intuitively first click on the "Send" button (and not the "Receive" button). That's the whole explanation. As I can get from your git commit this should work now. Please give me some time to test the results in the app.

Did you take a look at the two English strings (my second point), too?
THX! S.

sebasjm

2024-10-29 15:57

developer   ~0023619

i'm not sure I follow the last comment, let's close this issue (added the link in the receive ux fow) and discuss the i18n key in #translation channel on mattermost

Issue History

Date ModifiedUsernameFieldChange
2024-10-10 16:46StefanNew Issue
2024-10-10 16:46StefanStatusnew => assigned
2024-10-10 16:46StefanAssigned To => Florian Dold
2024-10-10 16:46StefanFile Added: Pull_request_in WebEx_wallet_under_Receive.png
2024-10-10 16:46StefanFile Added: Pull_request_in WebEx_wallet_done.png
2024-10-10 16:46StefanFile Added: Pull_request_in WebEx_wallet_balance.png
2024-10-10 19:26StefanDescription Updated
2024-10-10 19:36StefanDescription Updated
2024-10-28 11:26Florian DoldAssigned ToFlorian Dold => sebasjm
2024-10-28 16:33sebasjmNote Added: 0023609
2024-10-28 16:34sebasjmStatusassigned => informing
2024-10-28 16:34sebasjmResolutionopen => fixed
2024-10-28 16:34sebasjmNote Added: 0023610
2024-10-28 18:50StefanStatusinforming => feedback
2024-10-28 18:50StefanResolutionfixed => reopened
2024-10-28 18:50StefanNote Added: 0023611
2024-10-29 15:57sebasjmNote Added: 0023619
2024-10-29 15:57sebasjmStatusfeedback => informing
2024-10-29 15:57sebasjmResolutionreopened => no change required
2024-10-30 06:23Christian GrothoffFixed in Version => 0.14
2024-10-30 06:23Christian GrothoffTarget Version1.0 => 0.14
2024-12-13 18:15Christian GrothoffStatusinforming => closed