View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0009240 | Taler | merchant backend | public | 2024-10-02 13:24 | 2024-12-13 18:15 |
| Reporter | Christian Grothoff | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Platform | i7 | OS | Debian GNU/Linux | OS Version | squeeze |
| Product Version | git (master) | ||||
| Target Version | 0.14 | Fixed in Version | 0.14 | ||
| Summary | 0009240: test_merchant_product_creation fails | ||||
| Description | taler-merchant-keycheck didn't get the /keys from the exchange before order creation was attempted and then order creation fails. The main issue is whether the keycheck tool long-polls for /keys, as the test *does* wait until the exchange /keys is ready, but the merchant presumably doesn't notice on time. | ||||
| Steps To Reproduce | Bogdahn's (slow-ish) server had the test case failure. | ||||
| Tags | No tags attached. | ||||
| I tried to reproduce this, including artificially slowing down /keys generation on my system. Didn't work. I added a bit more logging that may help diagnose, but I think we need to try again on your VM to figure this one out... | |
| Timeline: 2024-10-06T11:53:11.101550+0000 taler-exchange-httpd-240051(H4ZFR6YBZEYC3SJ2YJ1H36XTE8) INFO Handling request (GET) for URL '/keys' 2024-10-06T11:53:11.204806+0000 taler-exchange-httpd-240051(H4ZFR6YBZEYC3SJ2YJ1H36XTE8) INFO Suspend ing /keys request until key material changes 2024-10-06T11:53:13.837262+0000 taler-merchant-httpd-240130(16FCGCFEPH8AA1S07CQQ19TZ14) INFO Trying to find chosen exchange `http://localhost:8081/' 2024-10-06T11:53:13.837281+0000 taler-merchant-httpd-240130(16FCGCFEPH8AA1S07CQQ19TZ14) INFO Still trying to (re)load http://localhost:8081/keys 2024-10-06T11:53:14.004834+0000 taler-exchange-httpd-240051(H4ZFR6YBZEYC3SJ2YJ1H36XTE8) INFO Request for `/keys' took 2903 ms 2024-10-06T11:53:14.087601+0000 taler-merchant-httpd-240130(16FCGCFEPH8AA1S07CQQ19TZ14) WARNING Cannot create order: lacking trusted exchanges 2024-10-06T11:53:14.016836+0000 taler-merchant-exchangekeyupdate-240128 INFO Received keys from URL `http://localhost:8081/keys' with status 200 and expiration Mon Oct 14 00:00:00 2024. 2024-10-06T11:53:14.170630+0000 taler-merchant-exchangekeyupdate-240128 INFO Committing merchant DB transaction update exchange key data | |
| Explanation: it seems things are mostly working: 1) The exchange is suspending /keys until it has the full response 2) The merchant exchangekeyupdate service is long-polling and serializing the result to the DB ASAP 3) The test case waits for /keys to be ready before launching into order creation 4) The merchant httpd service waits 250ms on /keys 5) But the merchant httpd service fails hard on order creation just before steps 1-4 can finish. | |
| Bumping the timeout to 750ms allows the test to pass. Bumped it to 2500ms in 4998506a..f0162d05 to be reasonable conservative also for even slower systems than this one. | |
| Note: you'll need to rebase your branch to get the test to pass. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-10-02 13:24 | Christian Grothoff | New Issue | |
| 2024-10-02 13:24 | Christian Grothoff | Status | new => assigned |
| 2024-10-02 13:24 | Christian Grothoff | Assigned To | => Christian Grothoff |
| 2024-10-02 18:22 | Christian Grothoff | Assigned To | Christian Grothoff => Bohdan |
| 2024-10-02 18:22 | Christian Grothoff | Status | assigned => feedback |
| 2024-10-02 18:22 | Christian Grothoff | Note Added: 0023429 | |
| 2024-10-05 20:32 | Christian Grothoff | Assigned To | Bohdan => Christian Grothoff |
| 2024-10-05 20:33 | Christian Grothoff | Status | feedback => assigned |
| 2024-10-06 11:59 | Christian Grothoff | Note Added: 0023447 | |
| 2024-10-06 12:04 | Christian Grothoff | Note Added: 0023448 | |
| 2024-10-06 12:05 | Christian Grothoff | Note Edited: 0023447 | |
| 2024-10-06 12:07 | Christian Grothoff | Note Added: 0023449 | |
| 2024-10-06 12:07 | Christian Grothoff | Status | assigned => informing |
| 2024-10-06 12:07 | Christian Grothoff | Resolution | open => fixed |
| 2024-10-06 12:07 | Christian Grothoff | Fixed in Version | => 0.14 |
| 2024-10-06 12:09 | Christian Grothoff | Note Added: 0023450 | |
| 2024-12-13 18:15 | Christian Grothoff | Status | informing => closed |
| 2025-03-22 13:09 | Christian Grothoff | Category | mechant backend => merchant backend |