View Issue Details

IDProjectCategoryView StatusLast Update
0009230Talercashier (Android App)public2024-12-13 18:15
Reportermikolai Assigned Toavalos Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.14Fixed in Version0.14 
Summary0009230: Already cancelled withdrawal can be confirmed during next (independant) withdrawal operation
DescriptionApparently, cancelling a withdrawal in the Cashier app does not delete the operation as expected, but somehow keeps the state. After starting a new withdrawal (even with another amount), it is possible to directly press "confirm" which does not confirm the new withdrawal, but the old one.

Happened once to me on Datenspuren, but can be reproduced with demo.taler.net.
Steps To Reproduce0. Login with bank account from demo.taler.net
1. start withdrawal in Cashier app (e.g. 5 KUDOS), see that confirm button is disabled
2. scan QR-code with (Android) wallet, confirm there
3. *cancel* the withdrawal in the cashier app, which leads you back to the initial screen automatically
4. see that the withdrawal is pending in the wallet
5. start a new withdrawal in Cashier app some time later (e.g. 10 KUDOS), see that confirm button is *not* disabled even though the withdrawal has not been confirmed on any wallet
6. click "confirm" before the wallet confirms
7. see that the first withdrawal of 5 KUDOS has been confirmed, both in Cashier and in wallet app
Additional InformationI haven't checked what happens if a wallet confirms the withdrawal between step 5 and 6, and whether confirming then confirms the first or the second withdrawal.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

avalos

2024-11-08 13:25

developer   ~0023680

Fixed! :)

commit a489ba3b76593764ecec6a5c29aecca445693a8a (HEAD -> master)
Author: Iván Ávalos <avalos@disroot.org>
Date: Fri Nov 8 14:24:35 2024 +0100

    [cashier] Always clean state after a withdrawal is aborted
    
    bug 0009230

Issue History

Date ModifiedUsernameFieldChange
2024-09-26 11:04mikolaiNew Issue
2024-09-26 11:04mikolaiStatusnew => assigned
2024-09-26 11:04mikolaiAssigned To => avalos
2024-09-29 18:38Christian GrothoffTarget Version => 1.0
2024-11-08 13:25avalosStatusassigned => informing
2024-11-08 13:25avalosResolutionopen => fixed
2024-11-08 13:25avalosNote Added: 0023680
2024-11-10 16:41Christian GrothoffProduct Version => git (master)
2024-11-10 16:41Christian GrothoffFixed in Version => 0.14
2024-11-10 16:41Christian GrothoffTarget Version1.0 => 0.14
2024-12-13 18:15Christian GrothoffStatusinforming => closed