View Issue Details

IDProjectCategoryView StatusLast Update
0009185Talerexchangepublic2024-12-13 18:15
ReporterChristian Grothoff Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeveritytweakReproducibilityN/A
Status closedResolutionfixed 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Product Versiongit (master) 
Target Version0.14Fixed in Version0.14 
Summary0009185: no signature from merchant_priv on /batch-deposit
DescriptionWith the recent KYC changes we assume that the merchant_pub signifies that the respective merchant agreed to the deposit, but actually the only signatures we (can) check are those from the coins. Now, usually the wallet should have checked that the merchant_sig under the contract is valid, but especially in the case where a wallet does a direct deposit, we cannot rely on this as obviously the wallet could put any random merchant_pub into the message signed by the coin_priv.

Thus, we need to update the protocol to have the merchant include the merchant_sig in the /batch-deposit, thus assuring us that the owner of merchant_priv did agree to the deposit.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2024-11-09 19:36

manager   ~0023681

Fixed with protocol v22 (c1be508a3..2d01575f5).

Issue History

Date ModifiedUsernameFieldChange
2024-09-11 18:01Christian GrothoffNew Issue
2024-09-11 18:01Christian GrothoffStatusnew => assigned
2024-09-11 18:01Christian GrothoffAssigned To => Christian Grothoff
2024-09-11 18:14Christian GrothoffAssigned ToChristian Grothoff => Florian Dold
2024-09-11 18:14Christian GrothoffStatusassigned => feedback
2024-09-11 18:15Christian GrothoffAssigned ToFlorian Dold => Christian Grothoff
2024-09-11 18:15Christian GrothoffStatusfeedback => assigned
2024-09-11 21:08Christian GrothoffAssigned ToChristian Grothoff =>
2024-09-11 21:08Christian GrothoffStatusassigned => implementing
2024-09-14 23:30Christian GrothoffTarget Version1.6 => 1.0 stretch goals
2024-09-16 21:52Christian GrothoffTarget Version1.0 stretch goals => 1.3
2024-11-02 16:47Christian GrothoffTarget Version1.3 => 1.0 stretch goals
2024-11-09 18:35Christian GrothoffAssigned To => Christian Grothoff
2024-11-09 18:35Christian GrothoffStatusimplementing => assigned
2024-11-09 19:36Christian GrothoffStatusassigned => informing
2024-11-09 19:36Christian GrothoffResolutionopen => fixed
2024-11-09 19:36Christian GrothoffFixed in Version => 0.14
2024-11-09 19:36Christian GrothoffNote Added: 0023681
2024-11-09 19:36Christian GrothoffTarget Version1.0 stretch goals => 0.14
2024-12-13 18:15Christian GrothoffStatusinforming => closed