View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0009184 | Taler | merchant backend | public | 2024-09-11 17:02 | 2024-09-17 14:29 |
| Reporter | Florian Dold | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Target Version | 0.14 | Fixed in Version | 0.14 | ||
| Summary | 0009184: merchant's /private/kyc returns status 204 despite zero deposit limit at exchange | ||||
| Description | $ taler-harness run-integrationtests kyc-merchant-deposit There is clearly a deposit limit configured. Note that a KYC auth key has *not* been set up in the test yet. I'm not sure if this is an issue with the exchange (see 0009174) or the merchant. | ||||
| Tags | No tags attached. | ||||
| Try sleep + loop, seems the KYC data is inserted milliseconds later... | |
| Unfortunately that doesn't seem to help. I've added the loop, but it still only returns 204: 2024-09-12T17:37:42.503Z test-kyc-merchant-deposit.ts INFO requesting GET http://localhost:8083/private/kyc 2024-09-12T17:37:42.504Z test-kyc-merchant-deposit.ts INFO mechant kyc status: 204 2024-09-12T17:37:43.005Z test-kyc-merchant-deposit.ts INFO requesting GET http://localhost:8083/private/kyc 2024-09-12T17:37:43.006Z test-kyc-merchant-deposit.ts INFO mechant kyc status: 204 [...] 2024-09-12T17:38:03.078Z test-kyc-merchant-deposit.ts INFO requesting GET http://localhost:8083/private/kyc 2024-09-12T17:38:03.079Z test-kyc-merchant-deposit.ts INFO mechant kyc status: 204 2024-09-12T17:38:03.580Z test-kyc-merchant-deposit.ts INFO requesting GET http://localhost:8083/private/kyc 2024-09-12T17:38:03.581Z test-kyc-merchant-deposit.ts INFO mechant kyc status: 204 | |
| The taler-merchant-kyccheck is running in the background, do I need to explicitly kick it somehow? | |
| Nah, that can't be it. I'll check again. | |
| Ok , I think the answer is this: the taler-merchant-kyccheck helper hangs *immediately* in the long-polling for /kyc-check, thus NEVER even creates any entry in merchant_kyc table, thus our SQL iterates over zero accounts x exchanges, thus returns 204. This is bad because then the default limits that do apply are also not returned (even though the logic to get them is present). Solution: have the kyccheck helper do a first pass with a long-poll timeout of zero to ensure we do have a non-empty table in the database. Then we should get a non-204 response. | |
| Fixed in 373c5628..6191cf20 | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-09-11 17:02 | Florian Dold | New Issue | |
| 2024-09-11 17:02 | Florian Dold | Status | new => assigned |
| 2024-09-11 17:02 | Florian Dold | Assigned To | => Christian Grothoff |
| 2024-09-12 15:08 | Christian Grothoff | Assigned To | Christian Grothoff => Florian Dold |
| 2024-09-12 15:08 | Christian Grothoff | Note Added: 0023271 | |
| 2024-09-12 17:37 | Florian Dold | Assigned To | Florian Dold => Christian Grothoff |
| 2024-09-12 17:38 | Florian Dold | Note Added: 0023272 | |
| 2024-09-12 17:38 | Florian Dold | Note Added: 0023273 | |
| 2024-09-12 21:29 | Christian Grothoff | Note Added: 0023278 | |
| 2024-09-13 09:12 | Christian Grothoff | Note Added: 0023280 | |
| 2024-09-13 18:35 | Christian Grothoff | Status | assigned => informing |
| 2024-09-13 18:35 | Christian Grothoff | Resolution | open => fixed |
| 2024-09-13 18:35 | Christian Grothoff | Fixed in Version | => 0.14 |
| 2024-09-13 18:35 | Christian Grothoff | Note Added: 0023286 | |
| 2024-09-17 14:29 | Christian Grothoff | Status | informing => closed |
| 2025-03-22 13:09 | Christian Grothoff | Category | mechant backend => merchant backend |