View Issue Details

IDProjectCategoryView StatusLast Update
0009183Talermerchant backendpublic2024-12-13 18:15
ReporterFlorian Dold Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.14Fixed in Version0.14 
Summary0009183: merchant backend reports unexpected error code when wallet deposits coins with bad exchange base URL
DescriptionThe merchant is configured to accept exchange base URL with master pub K1 and base URL B1.

The wallet, however, is configured to use the same exchange with K1 but a different base URL B2.

The old merchant handled this scenario perfectly well.

It's fine for the updated merchant (with the helper processes) to not handle this scenario, but the error response should not be a 5xx but a 4xx.
Steps To Reproduce$ taler-harness run-integrationtests merchant-exchange-confusion
Additional Information2024-09-11T14:41:57.372496+0200 taler-merchant-httpd-128454(5Y7TEGP77AY77ZB23XEPDVA78G) INFO Processing payment with exchange http://localhost:9081/
2024-09-11T14:41:57.372503+0200 taler-merchant-httpd-128454(5Y7TEGP77AY77ZB23XEPDVA78G) WARNING External protocol violation detected at taler-merchant-httpd_post-orders-ID-pay.c:1224.
2024-09-11T14:41:57.372533+0200 taler-merchant-httpd-128454(5Y7TEGP77AY77ZB23XEPDVA78G) INFO Processing /pay in phase 9
2024-09-11T14:41:57.372540+0200 taler-merchant-httpd-128454(5Y7TEGP77AY77ZB23XEPDVA78G) INFO Processing /pay in phase 11
2024-09-11T14:41:57.372591+0200 taler-merchant-httpd-128454(5Y7TEGP77AY77ZB23XEPDVA78G) INFO Request for `/orders/2024.255-01X9WSSR7Q7K6/pay' completed with HTTP status 504 (0)
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2024-09-13 22:49

manager   ~0023288

As per 6191cf20..e2354ce6, you now get a 400 Bad request status back. Tests still fails though...

Christian Grothoff

2024-09-16 12:21

manager   ~0023301

I would like to package the merchant 0.14 today or tomorrow for Datenspuren.de-event. AFAIK this is the only failing test. Is this quickly fixable?

Florian Dold

2024-09-17 16:24

manager   ~0023322

commit 360c6e9267df2a0df9a2b5643e3cbf707fff36ed (HEAD -> master, origin/master, origin/HEAD)
Author: Florian Dold <florian@dold.me>
Date: Tue Sep 17 18:22:53 2024 +0200

    harness: adjust merchant-exchange-confusion
    
    Merchant behavior has changed here.

Issue History

Date ModifiedUsernameFieldChange
2024-09-11 13:35Florian DoldNew Issue
2024-09-11 13:35Florian DoldStatusnew => assigned
2024-09-11 13:35Florian DoldAssigned To => Christian Grothoff
2024-09-13 22:49Christian GrothoffNote Added: 0023288
2024-09-13 22:49Christian GrothoffAssigned ToChristian Grothoff => Florian Dold
2024-09-16 12:21Christian GrothoffNote Added: 0023301
2024-09-17 16:24Florian DoldNote Added: 0023322
2024-09-17 16:24Florian DoldStatusassigned => informing
2024-09-17 16:24Florian DoldResolutionopen => fixed
2024-10-07 14:35Christian GrothoffFixed in Version => 0.14
2024-12-13 18:15Christian GrothoffStatusinforming => closed
2025-03-22 13:09Christian GrothoffCategorymechant backend => merchant backend