View Issue Details

IDProjectCategoryView StatusLast Update
0009169Talerspecificationpublic2024-09-17 14:29
Reportersebasjm Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PriorityhighSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.14Fixed in Version0.14 
Summary0009169: not clear what happen when the merchant gets 451 on /deposit [2d]
Descriptionwhen a wallet tries to pay an order but the merchant needs to complete kyc first.

1.- it should be clear the response code here https://docs.taler.net/core/api-merchant.html#post-[-instances-$INSTANCE]-orders-$ORDER_ID-pay
so the wallet can show enough information to know that the merchant is the one that need to complete kyc, and then try again

2.- define what do we want to show to the wallet user
the transaction failed, but the problem is transient since it can be repeated again and succeed

3.- merchant spa should show information about the current kyc status, so it can do the KYC way before hitting the limit (very bad case) and complete the kyc process

4.- consider offline point of sale, there could be situations that the merchant won't be able to complete kyc
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2024-09-04 15:07

manager   ~0023160

If we get a 451 on /deposit, we need to:
1) give the SPA an indication that KYC is required so that the merchant backend can prompt for KYC for the failing exchange;
2) return a new error to the wallet
3) so that the wallet can refresh the coins that could not be deposited, and
4a) the wallet MAY then choose to pay with coins from another exchange if available (goto 1), or
4b) the wallet tells the user "sorry, merchant didn't do their KYC yet, cannot pay

Christian Grothoff

2024-09-04 15:08

manager   ~0023161

And yes, the spec is missing in the API, and the merchant backend doesn't implement any of this yet.

Christian Grothoff

2024-09-05 14:13

manager   ~0023178

088dc2bc33d1b26f692bc1665eba69e1afd753d2 contains merchant protocol v17 with the respective specification updates. Note: not yet implemented!

Christian Grothoff

2024-09-06 13:47

manager   ~0023208

Spec is done, let's call #9052 the bug for the implementation in the SPA ;-).

Issue History

Date ModifiedUsernameFieldChange
2024-09-04 15:02sebasjmNew Issue
2024-09-04 15:02sebasjmStatusnew => assigned
2024-09-04 15:02sebasjmAssigned To => Christian Grothoff
2024-09-04 15:04Christian GrothoffProduct Version1.2 => git (master)
2024-09-04 15:05sebasjmDescription Updated
2024-09-04 15:07Christian GrothoffNote Added: 0023160
2024-09-04 15:08Christian GrothoffNote Added: 0023161
2024-09-05 11:39Christian GrothoffSummarynot clear what happen when the merchant gets 451 on /deposit => not clear what happen when the merchant gets 451 on /deposit [2d]
2024-09-05 14:13Christian GrothoffNote Added: 0023178
2024-09-06 13:47Christian GrothoffStatusassigned => informing
2024-09-06 13:47Christian GrothoffResolutionopen => fixed
2024-09-06 13:47Christian GrothoffFixed in Version => 0.14
2024-09-06 13:47Christian GrothoffNote Added: 0023208
2024-09-17 14:29Christian GrothoffStatusinforming => closed