View Issue Details

IDProjectCategoryView StatusLast Update
0009163Talerwallet-corepublic2024-12-13 18:15
Reporterericherman Assigned Toroot Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritylowSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.14Fixed in Version0.14 
Summary0009163: building wallet-core requires root access?
DescriptionThe README clearly states that pnpm is a requirement: https://git.taler.net/wallet-core.git/tree/README#n8

However, in my testing, it seems "make install" does not work with a locally installed `npm install pnpm`, (the PATH includes `./node_modules/.bin`), as it fails with the error:

 $ make install
 pnpm install --frozen-lockfile
 Scope: all 20 workspace projects
  ERR_PNPM_OUTDATED_LOCKFILE  Cannot install with "frozen-lockfile" because pnpm-lock.yaml is not up to date with package.json
 Note that in CI environments this setting is true by default. If you still need to run install in such cases, use "pnpm install --no-frozen-lockfile"
 make: *** [Makefile:270: install] Error 1
Steps To Reproduce# we do not have pnpm installed globally, no: sudo npm install -g pnpm

mkdir -pv ~/builds/wallet-core

git clone git://git.taler.net/wallet-core.git
cd wallet-core
export PATH=$(pwd)/node_modules/.bin:$PATH
./bootstrap
npm install pnpm
./configure --prefix=~/builds/wallet-core
make install
Additional Information1) It is noteworthy that when a `sudo npm install -g pnpm` is performed, then this error does not occur.

2) Reviewing the Makefile, it seems that `--frozen-lockfile` is a strong requirement (not intended to be over-written).
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Florian Dold

2024-10-04 13:41

manager   ~0023440

It's actually possible to install pnpm via npm without root access:

$ npm config set prefix $HOME/.npm-global
$ export PATH=$HOME.npm-global/bin:$PATH
$ npm install -g pnpm

I'm wondering, are there any installation instructions where we should add this?

Florian Dold

2024-10-04 13:43

manager   ~0023441

I've added this info to the README now.

Issue History

Date ModifiedUsernameFieldChange
2024-09-03 11:57erichermanNew Issue
2024-09-03 11:57erichermanStatusnew => assigned
2024-09-03 11:57erichermanAssigned To => Florian Dold
2024-10-04 13:41Florian DoldAssigned ToFlorian Dold => root
2024-10-04 13:41Florian DoldStatusassigned => feedback
2024-10-04 13:41Florian DoldNote Added: 0023440
2024-10-04 13:41Florian DoldTarget Version => 1.0
2024-10-04 13:43Florian DoldStatusfeedback => informing
2024-10-04 13:43Florian DoldResolutionopen => fixed
2024-10-04 13:43Florian DoldNote Added: 0023441
2024-10-06 15:54Christian GrothoffProduct Version => git (master)
2024-10-06 15:54Christian GrothoffFixed in Version => 0.14
2024-10-06 15:54Christian GrothoffTarget Version1.0 => 0.14
2024-12-13 18:15Christian GrothoffStatusinforming => closed