| Problem is that the amountAvailable as reported by wallet-core is not the "spendable" amount since fees need to be added (or rather subtracted from amountAvailable). And those fees might differ for different kind of transactions...
==> wallet-core needs to return the amountSpendable for each "prepare" or "check" call, so the wallets can show the user how much they can spend instead of throwing an ugly error message. |
|
| Here we want the `checkPeerPushDebitV2` request that only throws on unrecoverable panics but returns a (typed) error on insufficient balance. |
|
| Wallet-core now supports checkPeerPushDebitV2 with a tagged response type ("ok" and "insufficient-balance"). It only "panics" by throwing an exception on internal errors / completely unexpected situations.
Your original bug report says that an error message is returned when the amount is too small. I can't reproduce this behavior. |
|
| asked t3sserakt to reproduce... |
|
| I did not get any error, when trying to reproduce this. Now the wallet lowers the spendable amount to consider the fee. Only issue remaining, that i am not able to bring the amount of kudos to 0. But this issue can be closed, I think! |
|
| So, how can the user "empty" the wallet completely? |
|
| Discussed privately on mattermost already:
* UI shows as the maximum depositable amount the *effective* amount
* The UI's input field represents the *raw* amount
The wallet can easily convert from raw->effective but not the other way around.
To allow the user to deposit their full balance, we should show the *raw* amount as the maximum depositable amount! |
|
| t3sserakt confirmed (on Mattermost) that this doesn't happen anymore with v 0.14.4 |
|