View Issue Details

IDProjectCategoryView StatusLast Update
0009098Talerexchangepublic2024-09-17 14:29
ReporterFlorian Dold Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityblockReproducibilityN/A
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.14Fixed in Version0.14 
Summary0009098: deposit works despite OPERATION_TYPE=AGGREGATE rule that should trigger AML
DescriptionThe exchange's `deposits/...` endpoint for a deposit of TESTKUDOS:10 in total (multiple coins!) returns 200 (wired) for all coins with kyc_ok=true.

However, according to the KYC config, there is a TESTKUDOS:5 deposit threshold.
Steps To Reproduce$ taler-harness run-integrationtests kyc-deposit-aggregate

(Note that the test is *not* expected to succeed yet even with a correct exchange, as the deposit implementation does not fully support the new KYC API yet)
Additional Information[exchange]
enable_kyc = yes

[KYC-RULE-R1]
OPERATION_TYPE = aggregate
ENABLED = yes
EXPOSED = yes
IS_AND_COMBINATOR = yes
THRESHOLD = TESTKUDOS:5
TIMEFRAME = 1d
NEXT_MEASURES = M1

[KYC-MEASURE-M1]
CHECK_NAME = C1
CONTEXT = {}
PROGRAM = P1

[AML-PROGRAM-P1]
COMMAND = /bin/true
ENABLED = true
DESCRIPTION = this does nothing
FALLBACK = M1

[KYC-CHECK-C1]
TYPE = INFO
DESCRIPTION = my check!
FALLBACK = M1

TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2024-08-22 20:08

manager   ~0023034

Could you please make sure to log taler-exchange-aggregator at the INFO level during the test? I also added more logging logic to help diagnose this.

Florian Dold

2024-09-05 17:13

manager   ~0023181

Test works in taler-harness passes now.

Issue History

Date ModifiedUsernameFieldChange
2024-08-19 17:16Florian DoldNew Issue
2024-08-19 17:16Florian DoldStatusnew => assigned
2024-08-19 17:16Florian DoldAssigned To => Christian Grothoff
2024-08-22 20:08Christian GrothoffNote Added: 0023034
2024-08-22 20:09Christian GrothoffAssigned ToChristian Grothoff => Florian Dold
2024-08-22 20:09Christian GrothoffStatusassigned => feedback
2024-08-28 21:28Florian DoldTarget Version0.13 => 0.14
2024-09-05 17:13Florian DoldStatusfeedback => informing
2024-09-05 17:13Florian DoldResolutionopen => fixed
2024-09-05 17:13Florian DoldNote Added: 0023181
2024-09-05 17:27Christian GrothoffProduct Version => git (master)
2024-09-05 17:27Christian GrothoffFixed in Version => 0.14
2024-09-17 14:29Christian GrothoffStatusinforming => closed