View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0009038 | Taler | merchant backend | public | 2024-08-02 14:13 | 2026-09-19 14:40 |
| Reporter | sebasjm | Assigned To | Florian Dold | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | feature | Reproducibility | always |
| Status | informing | Resolution | fixed | ||
| Product Version | 0.13 | ||||
| Target Version | 1.6 | Fixed in Version | 1.6 | ||
| Summary | 0009038: fix category CRUD api | ||||
| Description | getting category by ID doesn't bring the list of products correctly the implementation doesn't include product description, it should by the API docs updating should also be tested | ||||
| Tags | No tags attached. | ||||
| I've fixed the select_category implementation (in C), and simplified the spec to NOT return description/description_i18n -- if the SPA needs those, it can fetch them individually from the product_id anyway. Re-assigning to sebasjm for testing with the SPA... | |
| curl 'http://merchant.taler.test:1180/private/categories/15' -X 'PATCH' --data-raw '{"name":"barato","name_i18n":{},"products":[{"product_id":"beer"}],"id":"15"}' can't change the lists of products of the category | |
| i suggest to mark it for post-1.0 we can add/remove categories from the product and in this screen (updating the category) I can limit to showing instead of editing | |
| I'm not sure what you are talking about. Is it that when the user views a category, they cannot edit the products there? That's kind-of intentional, they should select the product and change the category with the product. I guess it might be useful to be able to do such a change in both views (and with the category view add/remove products to the category), but indeed the API wasn't designed to support that (not with that PATCH on category). The SPA _could_, however, simply use the PATCH on the *product(s)* to add/remove a product from a category. So this is IMO a client-side thing -- the SPA should just use a different endpoint (and possibly might have to first to a GET on the product and then a PATCH). Anyway, if I understand correctly, I'd be happy to see this as a post-1.0 feature... | |
| Merchant API seems fine, and the UI for products/categories has been overhauled in the ng merchant webui. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-08-02 14:13 | sebasjm | New Issue | |
| 2024-08-02 14:13 | sebasjm | Status | new => assigned |
| 2024-08-02 14:13 | sebasjm | Assigned To | => sebasjm |
| 2024-08-04 20:15 | Christian Grothoff | Assigned To | sebasjm => Christian Grothoff |
| 2024-08-04 20:33 | Christian Grothoff | Note Added: 0022908 | |
| 2024-08-04 20:33 | Christian Grothoff | Assigned To | Christian Grothoff => sebasjm |
| 2024-08-07 15:33 | sebasjm | Note Added: 0022942 | |
| 2024-08-07 15:33 | sebasjm | Assigned To | sebasjm => Christian Grothoff |
| 2024-08-07 15:34 | sebasjm | Status | assigned => implementing |
| 2024-08-07 15:34 | sebasjm | Note Added: 0022943 | |
| 2024-08-07 16:04 | Christian Grothoff | Note Added: 0022946 | |
| 2024-08-07 16:04 | Christian Grothoff | Assigned To | Christian Grothoff => |
| 2024-08-07 16:04 | Christian Grothoff | Severity | major => feature |
| 2024-08-07 16:04 | Christian Grothoff | Target Version | 0.13 => post-1.0 |
| 2024-11-12 22:56 | Christian Grothoff | Target Version | post-1.0 => 1.5 |
| 2024-12-07 21:56 | Christian Grothoff | Assigned To | => Christian Grothoff |
| 2024-12-07 21:56 | Christian Grothoff | Status | implementing => assigned |
| 2024-12-22 22:16 | Christian Grothoff | Assigned To | Christian Grothoff => |
| 2024-12-22 22:16 | Christian Grothoff | Status | assigned => implementing |
| 2025-01-02 11:57 | Christian Grothoff | Priority | high => normal |
| 2025-03-22 13:09 | Christian Grothoff | Category | mechant backend => merchant backend |
| 2025-10-22 19:40 | Christian Grothoff | Status | implementing => acknowledged |
| 2025-10-23 10:57 | Christian Grothoff | Target Version | 1.5 => post-2.0 |
| 2026-08-27 07:41 | Florian Dold | Assigned To | => Florian Dold |
| 2026-08-27 07:41 | Florian Dold | Status | acknowledged => informing |
| 2026-08-27 07:41 | Florian Dold | Resolution | open => fixed |
| 2026-08-27 07:41 | Florian Dold | Note Added: 0029630 | |
| 2026-09-19 14:38 | Christian Grothoff | Target Version | post-2.0 => 1.6 |
| 2026-09-19 14:40 | Christian Grothoff | Fixed in Version | => 1.6 |