View Issue Details

IDProjectCategoryView StatusLast Update
0008999Talerlibeufin-bankpublic2025-08-31 17:09
ReporterAntoine A Assigned ToAntoine A Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityfeatureReproducibilityhave not tried
Status closedResolutionfixed 
Target Version1.0 stretch goalsFixed in Version1.0 stretch goals 
Summary0008999: Set limits to all variable size user inputs
DescriptionCurrently, all strings in all APIs are unsized and libeufin-bank accepts strings of any size. As libeufin-bank uses a very restrictive maximum size (4kB) on all decompressed bodies, this is not a serious security issue. However, it would be healthier to set reasonable limits on all variable-length entries such as wire transfer's subject, bearer token's description, account's name, account's username and so on.

Do we want to put those limits inside the API specification, if not how can we communicate those limits to clients?
Tagssecurity

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2025-04-17 20:24

manager   ~0024597

I think it is fine to put them into the API specification.

Antoine A

2025-05-21 15:51

manager   ~0024958

As we already have a very restrictive body limit, it only makes sense to limit the size of user input that ends up in URLs and that is only the case for the account username.
FIxed in 112e39a988b663a56d13f63d4c6d60ed53b22264

Issue History

Date ModifiedUsernameFieldChange
2024-07-01 09:35Antoine ANew Issue
2024-07-01 09:35Antoine AStatusnew => assigned
2024-07-01 09:35Antoine AAssigned To => Antoine A
2024-07-25 21:59Christian GrothoffTarget Version1.0 => post-1.0
2024-07-28 19:49Christian GrothoffSeverityminor => feature
2024-12-07 22:15Christian GrothoffTarget Versionpost-1.0 => 1.0 stretch goals
2025-04-17 20:24Christian GrothoffTag Attached: security
2025-04-17 20:24Christian GrothoffNote Added: 0024597
2025-05-21 15:51Antoine AStatusassigned => informing
2025-05-21 15:51Antoine AResolutionopen => fixed
2025-05-21 15:51Antoine ANote Added: 0024958
2025-06-03 17:52Christian GrothoffFixed in Version => 1.0 stretch goals
2025-08-31 17:09Christian GrothoffStatusinforming => closed