View Issue Details

IDProjectCategoryView StatusLast Update
0008987Talermerchant portal webuipublic2024-09-17 14:29
Reporteravalos Assigned Tosebasjm Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PriorityhighSeverityminorReproducibilityunable to reproduce
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.14Fixed in Version0.14 
Summary0008987: When adding a product, using a fractional number results in a validation error
DescriptionWhen you create a product in the merchant backend and use fractional numbers for the amount, when you press the "enter" button inside the amount field you get a validation error, and the uploaded image of the product disappears, then, when you correct the price to an integer number and you want to upload the image again, the upload button doesn't do anything.

Video: https://nextcloud.avalos.me/index.php/s/S2eXWBEy5L2cdKc
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

nullptrderef

2024-08-04 20:54

viewer   ~0022909

Last edited: 2024-08-04 21:05

Cannot reproduce on master (https://backend.head.taler.net) - is this still an issue?

see: https://files.catbox.moe/b8s6ca.mp4

avalos

2024-08-05 14:14

developer   ~0022922

Of course, keypresses are not visible on the screen recording, so, did you press enter inside the amount field after typing 0.5? That seemed to trigger the issue.

nullptrderef

2024-08-20 09:16

viewer   ~0023011

Last edited: 2024-08-20 09:16

> Of course, keypresses are not visible on the screen recording, so, did you press enter inside the amount field after typing 0.5? That seemed to trigger the issue.
nope, can reproduce it now - appears to be due to https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/step#min_impact_on_step

fixed in 02fadc83b997e4f5175d0dcd91ab925cebb08f47, see if still reproducible

avalos

2024-08-30 07:53

developer   ~0023114

I can't reproduce anymore, however, if I now press enter in any text field other than the description one (which is multi-line), the file chooser dialog for selecting the image pops up.

nullptrderef

2024-09-14 22:31

viewer   ~0023292

^ appears to have already been a bug - some weird things i don't quite understand cause it to press the first button in the DOM at enter time; removing the `Add` button will trigger it to press `Manage Stock` instead

this also happens for the 'Unit name' field which wouldn't have been affected by 02fadc83b997e4f5175d0dcd91ab925cebb08f47

Christian Grothoff

2024-09-16 12:19

manager   ~0023299

I would like to package the merchant 0.14 today or tomorrow for Datenspuren.de-event. Is this quickly fixable?

sebasjm

2024-09-16 15:27

developer   ~0023303

11233f014..a08d5dd17

image unload: added a workaround, the form will trigger the first button that it found and in this case is the InputImage button.

loading image 1, unloading and then loading image 1 again: it won't load since it won't trigger onChange action. This was fix updating the input element's value field when unloading the image.

Issue History

Date ModifiedUsernameFieldChange
2024-06-26 22:34avalosNew Issue
2024-06-26 22:34avalosStatusnew => assigned
2024-06-26 22:34avalosAssigned To => sebasjm
2024-07-28 20:07Christian GrothoffTarget Version => 0.14
2024-08-04 19:12Christian GrothoffAssigned Tosebasjm => nullptrderef
2024-08-04 20:54nullptrderefNote Added: 0022909
2024-08-04 20:56nullptrderefStatusassigned => feedback
2024-08-04 20:56nullptrderefReproducibilityhave not tried => unable to reproduce
2024-08-04 20:58nullptrderefNote Edited: 0022909
2024-08-04 21:05nullptrderefNote Edited: 0022909
2024-08-05 11:05Christian GrothoffAssigned Tonullptrderef => avalos
2024-08-05 14:14avalosNote Added: 0022922
2024-08-20 09:16nullptrderefNote Added: 0023011
2024-08-20 09:16nullptrderefNote Edited: 0023011
2024-08-30 07:53avalosNote Added: 0023114
2024-08-30 07:53avalosFile Added: Screenshot 2024-08-30 at 9.53.09 AM.png
2024-09-09 07:59Christian GrothoffAssigned Toavalos => nullptrderef
2024-09-09 07:59Christian GrothoffStatusfeedback => assigned
2024-09-13 22:59Christian GrothoffPrioritylow => high
2024-09-13 22:59Christian GrothoffProduct Version => git (master)
2024-09-14 22:31nullptrderefNote Added: 0023292
2024-09-14 22:35nullptrderefAssigned Tonullptrderef => sebasjm
2024-09-16 12:19Christian GrothoffNote Added: 0023299
2024-09-16 15:27sebasjmStatusassigned => informing
2024-09-16 15:27sebasjmResolutionopen => fixed
2024-09-16 15:27sebasjmNote Added: 0023303
2024-09-16 15:34Christian GrothoffFixed in Version => 0.14
2024-09-17 14:29Christian GrothoffStatusinforming => closed
2026-08-23 14:18Florian DoldCategorymerchant backoffice SPA => merchant portal webui