View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0008850 | Taler | wallet (WebExtension) | public | 2024-05-15 22:34 | 2024-07-25 22:11 |
| Reporter | Florian Dold | Assigned To | sebasjm | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | feature | Reproducibility | always |
| Status | closed | Resolution | won't fix | ||
| Target Version | 0.12 | Fixed in Version | 0.12 | ||
| Summary | 0008850: webext should call hintNetworkAvailability | ||||
| Description | The new wallet-core request hintNetworkAvailability({isNetworkAvailable: boolean}) should be used to tell wallet-core about network availability. In case the network becomes available again, all pending tasks are retried immediately. In the future, when the network becomes unavailable, wallet-core might stop emitting certain errors or not retry certain network requests. | ||||
| Tags | No tags attached. | ||||
| webex is listening two types of evenets 1.- window.addEventListener("offline", notifyOffline); window.addEventListener("online", notifyOnline); https://developer.mozilla.org/en-US/docs/Web/API/Window/offline_event 2.- navigator.connection.addEventListener("change", notifyChange); https://developer.mozilla.org/en-US/docs/Web/API/NetworkInformation/change_event None seems reliable. Works when changing the value in the devTool but does not respond to system changes. navigator.online has also wrong values https://developer.mozilla.org/en-US/docs/Web/API/Navigator/onLine It may work better in other OS but I think we can't relay on this feature. | |
| IMHO wallet-core should report the network error with a TalerErrorCode so the UI can decide: if this is a network error and (in case that UI can check network status) we are offline, the do not show the error msg. In browser it seems that we can't do it reliable on all platform. Tested on Ubuntu 23.04 firefox 123.0.1 chrome 122.0.6261.111 | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-05-15 22:34 | Florian Dold | New Issue | |
| 2024-05-15 22:34 | Florian Dold | Status | new => assigned |
| 2024-05-15 22:34 | Florian Dold | Assigned To | => sebasjm |
| 2024-05-15 22:34 | Florian Dold | Issue generated from: 0008849 | |
| 2024-05-15 22:34 | Florian Dold | Issue cloned: 0008851 | |
| 2024-05-27 17:02 | sebasjm | Category | wallet (Android App) => wallet (WebExtension) |
| 2024-05-28 17:32 | sebasjm | Note Added: 0022486 | |
| 2024-05-28 17:33 | sebasjm | Status | assigned => implementing |
| 2024-05-28 17:44 | sebasjm | Status | implementing => informing |
| 2024-05-28 17:44 | sebasjm | Resolution | open => won't fix |
| 2024-05-28 17:44 | sebasjm | Note Added: 0022487 | |
| 2024-07-25 22:11 | Christian Grothoff | Fixed in Version | => 0.12 |
| 2024-07-25 22:11 | Christian Grothoff | Status | informing => closed |