View Issue Details

IDProjectCategoryView StatusLast Update
0008838Talermerchant-pos-terminal (Android App)public2024-07-25 22:11
ReporterChristian Grothoff Assigned Toavalos Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PriorityhighSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Product Versiongit (master) 
Target Version0.12Fixed in Version0.12 
Summary0008838: support protocol v15 style /pos endpoint
DescriptionThe PoS terminal should support the new /pos endpoint. It makes a few minor changes:

1) no more locations; taxes and product image become optional;
2) no more configuration data is returned

The main change to the PoS terminal will be to ask the user for the merchant backend instance base URL (e.g. "https://merchant.com/instances/foo/") plus the access token ("secret-token:" prefix should probably be added if missing from user's data entry).

Then, the PoS should GET https://merchant.com/instances/foo/pos to obtain category and product information and proceed as before with everything else. So hopefully a modest change to the code.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

child of 0008834 closednullptrderef merchant backend should be able to generate PoS config JSON from inventory 

Activities

Christian Grothoff

2024-05-13 11:45

manager   ~0022400

Not sure who's best to hack this in, Ivan or grote, so feel free to re-assign/bounce the issue between the two of you.

avalos

2024-05-22 19:54

developer   ~0022457

Can I test this already? Both demo.taler.net and test.taler.net throw 404.

$ http https://backend.test.taler.net/instances/pos/pos
HTTP/1.1 404 Not Found
Access-Control-Allow-Origin: *
Access-Control-Expose-Headers: *
Connection: keep-alive
Content-Encoding: deflate
Content-Length: 167
Content-Type: application/json
Date: Wed, 22 May 2024 19:53:41 GMT
Server: nginx

{
    "code": 21,
    "detail": "/instances/pos/pos",
    "hint": "There is no endpoint defined for the URL provided by the client. Check if you used the correct URL and/or file a report with the developers of the client software."
}

avalos

2024-06-03 14:17

developer   ~0022498

Implemented in dev/ivan-avalos/merchant-v15, waiting for review.

avalos

2024-06-04 20:16

developer   ~0022515

Implemented in 6e21df1b59a134409d43d251175792d06e0451c6..c90356e99fec4b4ba39a08e7910880bd7accfa3c.

Issue History

Date ModifiedUsernameFieldChange
2024-05-13 11:44Christian GrothoffNew Issue
2024-05-13 11:44Christian GrothoffStatusnew => assigned
2024-05-13 11:44Christian GrothoffAssigned To => avalos
2024-05-13 11:45Christian GrothoffNote Added: 0022400
2024-05-13 11:45Christian GrothoffRelationship addedchild of 0008834
2024-05-22 15:23Florian DoldTarget Version0.14 => 0.12
2024-05-22 19:54avalosNote Added: 0022457
2024-06-03 14:17avalosAssigned Toavalos => grote
2024-06-03 14:17avalosStatusassigned => feedback
2024-06-03 14:17avalosNote Added: 0022498
2024-06-04 20:16avalosAssigned Togrote => avalos
2024-06-04 20:16avalosStatusfeedback => informing
2024-06-04 20:16avalosResolutionopen => fixed
2024-06-04 20:16avalosNote Added: 0022515
2024-07-25 22:11Christian GrothoffFixed in Version => 0.12
2024-07-25 22:11Christian GrothoffStatusinforming => closed