| It's a negative fee issue again, I still don't know how to handle those. Is this fine? ``` if (t.amountEffective > t.amountRaw) { val fee = t.amountEffective - t.amountRaw if (!fee.isZero()) { TransactionAmountComposable( label = stringResource(id = R.string.withdraw_fees), amount = fee.withSpec(spec), amountType = AmountType.Negative, ) } } ``` If the fee will be negative, it simply doesn't show it. | |
| This is how an aborted peer-push debit transaction would be rendered. Screenshot_20240513_093458.png (37,382 bytes) | |
| How can the fee be negative? It crashes in deployments where there is *no* fee at all! | |
| The result of subtracting the raw amount to the effective amount is negative: ``` { "type": "peer-push-debit", "txState": { "major": "aborting", "minor": "delete-purse" }, "txActions": [ "suspend", "fail" ], "amountEffective": "KUDOS:0", "amountRaw": "KUDOS:0.2", "exchangeBaseUrl": "https://exchange.demo.taler.net/", "info": { "expiration": { "t_s": 1715705913 }, "summary": "Crash!" }, "timestamp": { "t_s": 1715619513, "off_us": 773000 }, "transactionId": "txn:peer-push-debit:VMDTHY695CW6A5PYE20XW85A47PFA150B7B7RD36Q4F8J84VZMWG" } ``` | |
| Additional checks for negative fees have been implemented in dev/ivan-avalos/master. | |
| fix merged into master | |
- Anonymous