View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0008768 | Taler | wallet-core | public | 2024-04-24 17:03 | 2024-08-28 21:30 |
| Reporter | sebasjm | Assigned To | Florian Dold | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | low | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 0.11 | ||||
| Target Version | 0.13 | Fixed in Version | 0.13 | ||
| Summary | 0008768: obs event: add a request handler to listen particular events [2h] | ||||
| Description | for example, if the user is waiting in the tx details view the only events shown will be the ones related to the actions taking into that screen (if the filter described in https://bugs.gnunet.org/view.php?id=8767 is implemented) the some activity in wallet core may be related to the current tx can take place (some tasks) to fix this, the UI should call this new request handler like: wallet.listenToTransactionTask(taskId) it will not return (may be cancelled by UI) and while this request is open all the ob events related to the `taskId` will be reported as related to this wallet request. with this we expect to ob even UI to show for example: database access or net request when the user is waiting in a withdrawal page or checking the purchase ticket (since it may have auto refund enabled) | ||||
| Tags | No tags attached. | ||||
| related to | 0008767 | implementing | observavility events: add a filter to show events trigger by actions called in the current screen. [6hs] |
| We currently don't do subscriptions for wallet-core notifications. So I'm not sure how we would easily implement this. Maybe instead we can have a request to map a transaction ID to a list of task IDs (where the UI then filters relevant events for these tasks)? Sebastian, would that work? Alternatively we could indeed implement filtered notification subscriptions, but that would be a lot more complex. | |
| ok, if we have taskList = wallet.currentTasks(txId) and the we should keep that list updated, we will need an event to know when we should call it again and get an updated list. alternative, we can change this requirement to "there must be a way to get the Tx ID if the background operation is related to a transaction" for example: let's say that there is a cryptoStart event, if this comes from a withdrawal task... even if the withdrawal is not triggered by the current view (no wallet core operation has been called) the obs event must come with the txId so it can be filtered by the view. | |
| I think the former (getting task IDs from transactions) is just *way* simpler. | |
| We now have a new event type to make the connection between requests/tasks and transactions: /** * Declare that an observability event is relevant to a particular transaction. * If emitted from a request/task, all past/future events for that request/task * should be shown for the transaction as well. */ DeclareConcernsTransaction = "declare-concerns-transaction", | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-04-24 17:03 | sebasjm | New Issue | |
| 2024-04-24 17:03 | sebasjm | Status | new => assigned |
| 2024-04-24 17:03 | sebasjm | Assigned To | => Florian Dold |
| 2024-04-29 16:27 | Florian Dold | Note Added: 0022318 | |
| 2024-04-29 16:28 | Florian Dold | Assigned To | Florian Dold => sebasjm |
| 2024-04-29 16:28 | Florian Dold | Status | assigned => feedback |
| 2024-05-06 20:18 | sebasjm | Note Added: 0022362 | |
| 2024-05-06 20:18 | sebasjm | Assigned To | sebasjm => Florian Dold |
| 2024-05-13 19:29 | Christian Grothoff | Target Version | 0.11 => 0.12 |
| 2024-06-16 15:49 | Florian Dold | Priority | normal => low |
| 2024-06-16 16:02 | Florian Dold | Note Added: 0022626 | |
| 2024-06-16 16:02 | Florian Dold | Summary | obs event: add a request handler to listen particular events => obs event: add a request handler to listen particular events [2h] |
| 2024-06-16 20:31 | sebasjm | Relationship added | related to 0008767 |
| 2024-06-18 15:53 | sebasjm | Target Version | 0.12 => 0.13 |
| 2024-06-30 18:38 | Florian Dold | Status | feedback => informing |
| 2024-06-30 18:38 | Florian Dold | Resolution | open => fixed |
| 2024-06-30 18:38 | Florian Dold | Note Added: 0022771 | |
| 2024-08-26 20:30 | Christian Grothoff | Fixed in Version | => 0.13 |
| 2024-08-28 21:30 | Christian Grothoff | Status | informing => closed |