View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0008716 | Taler | merchant portal webui | public | 2024-04-09 14:54 | 2024-04-15 19:32 |
| Reporter | sebasjm | Assigned To | sebasjm | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | tweak | Reproducibility | sometimes |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 0.10 | Fixed in Version | 0.10 | ||
| Summary | 0008716: wrong refund deadline | ||||
| Description | doing some testing i found one order which from which merchant backend returned with contract_terms.refund_deadline.t_s = 0 the merchant SPA rendered as "refundable at 1969". SPA expect refund deadline after order creatiion or "never" to hide it. the order was still payable (before pay deadline) but it was claim long after it was created. current config: instance default payment delay: 2h instance default wire transfer delay: 2d | ||||
| Tags | No tags attached. | ||||
| I don't think this is wrong at all. The way I read it, the spec says that the refund_deadline field is *mandatory*. So I have to set it. We also say that if the refund deadline is in the past, the order is simply *not refundable*. So 0 < any pay deadline, so not refundable. I think you should just check if the refund deadline is in the past (and 1970 is definitively in the past!), and then not show 'refundable' at all, because it clearly was never refundable. | |
| ACK updating in merchant SPA | |
| 7f3253333 | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-04-09 14:54 | sebasjm | New Issue | |
| 2024-04-09 14:54 | sebasjm | Status | new => assigned |
| 2024-04-09 14:54 | sebasjm | Assigned To | => Christian Grothoff |
| 2024-04-09 15:10 | Christian Grothoff | Note Added: 0022169 | |
| 2024-04-09 15:10 | Christian Grothoff | Assigned To | Christian Grothoff => sebasjm |
| 2024-04-09 15:10 | Christian Grothoff | Severity | minor => tweak |
| 2024-04-09 16:22 | sebasjm | Category | mechant backend => merchant backoffice SPA |
| 2024-04-09 16:22 | sebasjm | Note Added: 0022174 | |
| 2024-04-09 16:23 | sebasjm | Status | assigned => informing |
| 2024-04-09 16:23 | sebasjm | Resolution | open => fixed |
| 2024-04-09 16:23 | sebasjm | Note Added: 0022175 | |
| 2024-04-09 16:23 | sebasjm | Status | informing => feedback |
| 2024-04-09 16:23 | sebasjm | Resolution | fixed => reopened |
| 2024-04-09 16:23 | sebasjm | Target Version | 0.11 => 0.10 |
| 2024-04-09 16:23 | sebasjm | Status | feedback => informing |
| 2024-04-09 16:23 | sebasjm | Resolution | reopened => fixed |
| 2024-04-11 23:50 | Christian Grothoff | Fixed in Version | => 0.10 |
| 2024-04-15 19:32 | Christian Grothoff | Status | informing => closed |
| 2026-08-23 14:18 | Florian Dold | Category | merchant backoffice SPA => merchant portal webui |