View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0008658 | Taler | merchant backend | public | 2024-03-22 12:58 | 2024-04-15 19:33 |
| Reporter | fefe | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 0.10 | Fixed in Version | 0.10 | ||
| Summary | 0008658: handle_config_finished: num_eci should be size_t | ||||
| Description | In merchant/src/lib/merchant_api_get_config.c: 86 static void 87 handle_config_finished (void *cls, 88 long response_code, 89 const void *response) 110 unsigned int num_eci = 0; 158 num_eci = json_object_size (exchanges); json_object_size returns a size_t, so num_eci should be a size_t. | ||||
| Tags | No tags attached. | ||||
| 161 for (unsigned int i = 0; i<num_eci; i++) this should be a size_t as well | |
| I prefer to keep unsigned int, as that's exposed in the external API. Added a cast, a check that the size_t value is the same, plus an upper bound of 1024, both for this array and the jcs currency spec object. Fixed pushed in 6d41df4..2c9b6f5. Oh, and the break logic was very broken (some missing, sometimes not calling the CB). Fixed that now, too. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-03-22 12:58 | fefe | New Issue | |
| 2024-03-22 12:58 | fefe | Status | new => assigned |
| 2024-03-22 12:58 | fefe | Assigned To | => Christian Grothoff |
| 2024-03-22 12:59 | fefe | Note Added: 0021973 | |
| 2024-03-22 13:14 | Christian Grothoff | Note Added: 0021974 | |
| 2024-03-22 13:17 | Christian Grothoff | Note Edited: 0021974 | |
| 2024-03-22 13:18 | Christian Grothoff | Status | assigned => informing |
| 2024-03-22 13:18 | Christian Grothoff | Resolution | open => fixed |
| 2024-03-22 13:18 | Christian Grothoff | Fixed in Version | => 0.10 |
| 2024-03-22 13:18 | Christian Grothoff | Target Version | git (master) => 0.10 |
| 2024-04-15 19:33 | Christian Grothoff | Status | informing => closed |
| 2025-03-22 13:09 | Christian Grothoff | Category | mechant backend => merchant backend |