View Issue Details

IDProjectCategoryView StatusLast Update
0008653Talerwallet-corepublic2024-04-15 19:32
Reportersebasjm Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeveritytweakReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.10Fixed in Version0.10 
Summary0008653: update coin selection algorithm: do not use amortization [estimate: 2h]
Descriptionmerchant doesn't return that info anymore https://docs.taler.net/core/api-merchant.html#the-contract-terms

wallet-core use that info for coin selection and now it is always 1 (for amort) and no age restriction.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

sebasjm

2024-03-22 12:28

developer   ~0021972

min age was not in the contract term but as a mistake, so I reverted back the removal of minimum_age.

still amortization was removed

Florian Dold

2024-04-04 19:11

manager   ~0022116

commit 01838bfcc74a2e4e828885d5ab0d6f64cc96f328 (HEAD -> master, origin/master, origin/HEAD)
Author: Florian Dold <florian@dold.me>
Date: Thu Apr 4 21:09:52 2024 +0200

    wallet-core: remove wire fee amortization
    
    It doesn't exist anymore as a concept in the merchant.

Issue History

Date ModifiedUsernameFieldChange
2024-03-20 01:51sebasjmNew Issue
2024-03-20 01:51sebasjmStatusnew => assigned
2024-03-20 01:51sebasjmAssigned To => Florian Dold
2024-03-22 12:28sebasjmNote Added: 0021972
2024-03-27 20:24Florian DoldSummaryupdate coin selection algorithm: do not use amortization and min age => update coin selection algorithm: do not use amortization and min age [estimate: 2h]
2024-04-03 12:50Florian DoldSummaryupdate coin selection algorithm: do not use amortization and min age [estimate: 2h] => update coin selection algorithm: do not use amortization [estimate: 2h]
2024-04-03 12:50Florian DoldProduct Version0.11 =>
2024-04-03 12:50Florian DoldTarget Version0.11 => 0.10
2024-04-04 19:11Florian DoldStatusassigned => informing
2024-04-04 19:11Florian DoldResolutionopen => fixed
2024-04-04 19:11Florian DoldNote Added: 0022116
2024-04-09 11:11Christian GrothoffFixed in Version => 0.10
2024-04-15 19:32Christian GrothoffStatusinforming => closed