View Issue Details

IDProjectCategoryView StatusLast Update
0008539Talerqtartpublic2024-07-25 22:12
ReporterFlorian Dold Assigned Toavalos Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritylowSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.12Fixed in Version0.12 
Summary0008539: os.fetchHttp does not allow cancellation [estimate: 7h]
DescriptionWe currently just ignore the result if the request is cancelled.

Instead, os.fetchHttp should return a cancellation function together with the promise.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Florian Dold

2024-02-28 13:59

manager   ~0021551

Or as a separate argument in the options. I.e. an object that will receive the cancellation function.

avalos

2024-05-24 18:36

developer   ~0022466

WIP in `dev/ivan-avalos/cancel-fetch` branch of `wallet-core.git` and `quickjs-tart.git` repositories.

avalos

2024-05-29 14:49

developer   ~0022490

Implemented in wallet-core a976b03cd1917d576d084726529427e709d5fe3f..d985c0ba04d06ebc9c584c2e17bed68350d82136 and quickjs-tart f7b6b6bbafd589774e7f439c12e92415db0cae50..cae2f55bb924a2395dafe8fec60090b10468d40a.

Issue History

Date ModifiedUsernameFieldChange
2024-02-28 10:07Florian DoldNew Issue
2024-02-28 10:07Florian DoldStatusnew => assigned
2024-02-28 10:07Florian DoldAssigned To => Florian Dold
2024-02-28 13:59Florian DoldNote Added: 0021551
2024-03-07 13:07Florian DoldTarget Version0.10 => 0.11
2024-03-27 20:23Florian DoldSummaryos.fetchHttp does not allow cancellation => os.fetchHttp does not allow cancellation [estimate: 7h]
2024-04-04 20:01Florian DoldPrioritynormal => low
2024-05-15 16:53Florian DoldTarget Version0.11 => 0.12
2024-05-23 22:59Florian DoldAssigned ToFlorian Dold => avalos
2024-05-24 18:36avalosNote Added: 0022466
2024-05-24 18:41avalosStatusassigned => implementing
2024-05-25 04:47avalosAssigned Toavalos => Florian Dold
2024-05-25 04:47avalosStatusimplementing => feedback
2024-05-29 14:49avalosAssigned ToFlorian Dold => avalos
2024-05-29 14:49avalosStatusfeedback => informing
2024-05-29 14:49avalosResolutionopen => fixed
2024-05-29 14:49avalosFixed in Version => git (master)
2024-05-29 14:49avalosNote Added: 0022490
2024-06-17 08:34Christian GrothoffProduct Version => git (master)
2024-06-17 08:34Christian GrothoffFixed in Versiongit (master) => 0.12
2024-07-25 22:12Christian GrothoffStatusinforming => closed