View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0008493 | Taler | exchange | public | 2024-02-22 19:55 | 2024-02-23 13:00 |
| Reporter | Florian Dold | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | no change required | ||
| Target Version | 0.9.4 | Fixed in Version | 0.9.4 | ||
| Summary | 0008493: exchange sends two Vary headers for /terms response, causing browsers to return cached response even when the language changes | ||||
| Description | $ curl https://exchange.test.taler.net/terms < vary: Accept-Encoding < etag: exchange-tos-v0 [...] < vary: Accept-Language,Accept,Accept-Encoding | ||||
| Tags | No tags attached. | ||||
| I read https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Vary that the server is exactly doing what the spec says: specify which HTTP request headers may have influenced the response generation, so that a browser or cache should NOT (necessarily) return the cached version if the HTTP request headers changed. Now, if a browser doesn't respect this, that's another story, but where do you think I'm misreading the spec? | |
| Oh, sorry. The issue is that we set TWO vary headers, right? | |
| Eh, I just checked, and Firefox only shows one VARY header. And the code only has ONE place where ONE vary header is set. | |
| Interesting, curl and Firefox disagree! More interesting: curl only shows *1* vary header when run against the Exchange without nginx proxy! | |
| nginx.conf: gzip_vary on; instructs nginx to add such a 'Vary' header. I think this is the real culprit, as Nginx just adds another vary header, not caring what already exists. So no, there won't be an Exchange test for this, it wouldn't catch anything anyway! | |
| This is actually OK, the browser combines multiple headers. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-02-22 19:55 | Florian Dold | New Issue | |
| 2024-02-22 19:55 | Florian Dold | Status | new => assigned |
| 2024-02-22 19:55 | Florian Dold | Assigned To | => Christian Grothoff |
| 2024-02-22 20:53 | Christian Grothoff | Note Added: 0021465 | |
| 2024-02-22 20:53 | Christian Grothoff | Note Added: 0021466 | |
| 2024-02-22 20:56 | Christian Grothoff | Note Added: 0021467 | |
| 2024-02-22 21:00 | Christian Grothoff | Note Added: 0021468 | |
| 2024-02-22 21:01 | Christian Grothoff | Note Added: 0021469 | |
| 2024-02-22 21:04 | Christian Grothoff | Assigned To | Christian Grothoff => javier.sepulveda |
| 2024-02-23 13:00 | Christian Grothoff | Assigned To | javier.sepulveda => Christian Grothoff |
| 2024-02-23 13:00 | Christian Grothoff | Status | assigned => closed |
| 2024-02-23 13:00 | Christian Grothoff | Resolution | open => no change required |
| 2024-02-23 13:00 | Christian Grothoff | Fixed in Version | => 0.9.4 |
| 2024-02-23 13:00 | Christian Grothoff | Note Added: 0021477 |