View Issue Details

IDProjectCategoryView StatusLast Update
0008457Talerwallet (WebExtension)public2024-03-07 19:51
ReporterFlorian Dold Assigned Tosebasjm Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.9.4Fixed in Version0.9.4 
Summary0008457: webext requests ToS as text/xml and fails to render it
DescriptionScreenshot posted on mattermost.

I'm not sure why we're even requesting text/xml. What format are we exactly expecting?
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

related to 0008483 closedsebasjm exchange ToS are not properly rendered as HTML 

Activities

sebasjm

2024-02-21 13:53

developer   ~0021404

nothing in webex changed here, this is result of breaking changes and no testing

1. format of TOS changed, XML stopped to work and was never tested. webex always used XML
using the node names (title, paragraph, section.... ) it creates proper HTML with CSS and JS to create for example the dropdown section.

2. exchange don't return content-type when etag match

wallet-core first query text/plain and browser save etag in cache

3. wallet core assume content type = plain when content-type is not present in request response

sebasjm

2024-02-21 13:55

developer   ~0021405

i have downgraded webex to ask for HTML (will create an iframe), but HTML is also wrong since is showing # as markdown when it shouldn't

commit c5fecc1ac

the exchange bug still present, to test I needed to disable browser cache

Florian Dold

2024-02-23 16:48

manager   ~0021483

Not sure if there is a problem.

@sebasjm: Can you please clarify this a bit?

sebasjm

2024-02-28 14:38

developer   ~0021553

this problems was due a complete rewrite of the RST

Issue History

Date ModifiedUsernameFieldChange
2024-02-21 11:06Florian DoldNew Issue
2024-02-21 11:06Florian DoldStatusnew => assigned
2024-02-21 11:06Florian DoldAssigned To => sebasjm
2024-02-21 13:53sebasjmNote Added: 0021404
2024-02-21 13:55sebasjmNote Added: 0021405
2024-02-21 13:55sebasjmAssigned Tosebasjm => Florian Dold
2024-02-21 13:55sebasjmStatusassigned => feedback
2024-02-21 21:34sebasjmRelationship addedrelated to 0008483
2024-02-23 16:47Florian DoldAssigned ToFlorian Dold => sebasjm
2024-02-23 16:48Florian DoldNote Added: 0021483
2024-02-23 16:48Florian DoldStatusfeedback => assigned
2024-02-28 14:38sebasjmStatusassigned => informing
2024-02-28 14:38sebasjmResolutionopen => fixed
2024-02-28 14:38sebasjmNote Added: 0021553
2024-03-07 19:50Christian GrothoffFixed in Version => 0.9.4
2024-03-07 19:51Christian GrothoffStatusinforming => closed