View Issue Details

IDProjectCategoryView StatusLast Update
0008455Talerwallet (Android App)public2024-03-07 19:52
ReporterFlorian Dold Assigned Toavalos Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.9.4Fixed in Version0.9.4 
Summary0008455: wallet should reset DB via the "clearDb" instead of manually deleting the database file
DescriptionThe manual reset does not seem to work reliably. Instead, the reset button should use the wallet-core "clearDb" request.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

avalos

2024-02-21 14:25

developer   ~0021406

We're using "clearDb," so if it doesn't work reliably, then it must mean another thing.
 https://git.taler.net/taler-android.git/tree/wallet/src/main/java/net/taler/wallet/MainViewModel.kt#n157

What do you mean by "does not seem to work reliably"? Could you describe it a bit further? Is it the UI that doesn't react to the reset, or is it that the wallet is not being reset consistently?

avalos

2024-02-21 14:27

developer   ~0021407

However, now I see that the app is not even waiting for confirmation from wallet-core, and is not even catching errors, but rather simply updating the UI after the clearDb request is performed. I'll check that out, maybe some error going on.

Florian Dold

2024-02-22 17:18

manager   ~0021461

Maybe there is some concurrency issue? You are issuing the request, but I'm not sure if you're waiting it to finish.

So maybe you're invalidating the balances view *before* the reset actually happens.

Did you test the reset functionality with a non-empty wallet yourself?

avalos

2024-02-25 20:32

developer   ~0021505

Should be fixed in 506e74e4aa26c18cc3538f01d9fc588272a3ebe0 (currently in dev/ivan-avalos/master).

Issue History

Date ModifiedUsernameFieldChange
2024-02-20 19:09Florian DoldNew Issue
2024-02-20 19:09Florian DoldStatusnew => assigned
2024-02-20 19:09Florian DoldAssigned To => avalos
2024-02-21 14:25avalosNote Added: 0021406
2024-02-21 14:27avalosNote Added: 0021407
2024-02-22 17:18Florian DoldNote Added: 0021461
2024-02-25 20:32avalosNote Added: 0021505
2024-02-26 23:14avalosStatusassigned => informing
2024-02-26 23:14avalosResolutionopen => fixed
2024-03-07 19:52Christian GrothoffFixed in Version => 0.9.4
2024-03-07 19:52Christian GrothoffStatusinforming => closed