View Issue Details

IDProjectCategoryView StatusLast Update
0008429Talerwallet-corepublic2024-03-07 19:52
ReporterMarcS Assigned ToMarcS Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PriorityhighSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.9.4Fixed in Version0.9.4 
Summary0008429: getTransactions result doesn't have deposit transactions
Descriptionlatest wallet-core still doesn't report deposit

WalletCore#1 handleResponse(_:) id:0 ["versionInfo": ["bank": "1:0:0", "merchant": "5:0:1", "implementationGitHash": "490ef893e04d0515c3093a5a3e1cf14e707f3ea6", "bankConversionApiRange": "2:0:0", "exchange": "17:0:0", "devMode": false, "bankIntegrationApiRange": "1:0:0", "corebankApiRange": "2:0:0", "version": "3:0:2", "implementationSemver": "0.9.4-dev.14"]]


withdraw 10, deposit 5


WalletCore#1 handleNotification(_:) ["oldTxState": ["major": "pending", "minor": "deposit"], "newTxState": ["minor": "track", "major": "pending"], "transactionId": "txn:deposit:2KT3RT1BTBSHY94SC9WF24N5RJ8WAKW43A2W2X823WZQQC5DFSSG", "type": "transaction-state-transition"]
 WalletCore#1 handleNotification(_:) ["transactionId": "txn:refresh:3V188FZCS3BHFF5XVZSJYMAQR0X516N7FAYHYJ76RP3MK9NRXYE0", "newTxState": ["major": "done"], "type": "transaction-state-transition", "oldTxState": ["major": "pending"]]

 WalletCore#1 sendRequest(request:completionHandler:) {"operation":"getBalances","args":{},"id":30}
 WalletCore#1 handleResponse(_:) id:30 ["balances": [["pendingIncoming": "KUDOS:0", "flags": [], "requiresUserInput": false, "scopeInfo": ["type": "exchange", "url": "https://exchange.demo.taler.net/", "currency": "KUDOS"], "available": "KUDOS:5", "hasPendingTransactions": false, "pendingOutgoing": "KUDOS:0"]]]
Request "id":30 took 14 ms


should have "pendingOutgoing": "KUDOS:5"


 WalletCore#1 sendRequest(request:completionHandler:) {"operation":"getTransactions","id":31,"args":{"sort":"descending","scopeInfo":{"url":"https:\/\/exchange.demo.taler.net\/","type":"exchange","currency":"KUDOS"},"currency":"KUDOS"}}
  WalletCore#1 handleResponse(_:) id:31 ["transactions": [["timestamp": ["t_s": 1708060760, "off_us": 844000], "amountRaw": "KUDOS:10", "amountEffective": "KUDOS:10", "txActions": ["delete"], "txState": ["major": "done"], "exchangeBaseUrl": "https://exchange.demo.taler.net/", "type": "withdrawal", "withdrawalDetails": ["reservePub": "QHA4TS6W7HNX7RBZ8KY6JTMGPY0G1G0KSVVGGR2SAVHYYZATGFQ0", "type": "taler-bank-integration-api", "confirmed": true, "exchangeCreditAccountDetails": [["paytoUri": "payto://iban/DE159593?receiver-name=Sandcastle+Echange+Inc&amount=KUDOS%3A10", "creditRestrictions": [], "status": "ok", "transferAmount": "KUDOS:10"]], "bankConfirmationUrl": "https://bank.demo.taler.net:443/webui/#/operation/e8565863-e6ad-4945-a0a6-77e3d5bfcf8e", "reserveIsReady": true], "transactionId": "txn:withdrawal:R1DMBE1G5CQ525VWWWG82Y56RMNCVK7CZX2V836NMT8JSHEN2EB0"]]]
Request "id":31 took 5 ms


should have the pending deposit transaction

after scopeInfo got added to getTransactions, the result doesn't have deposit transactions.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

child of 0008237 closedMarcS The iOS wallet should implement deposit 

Activities

sebasjm

2024-02-19 18:32

developer   ~0021379

I can't reproduce or I need more info, do you have an error?

webex get the deposit calling WalletApiOperation.GetTransactions filtered with scopeInfo and sorted "descending"

sebasjm

2024-02-19 18:41

developer   ~0021380

i can see that pendingOutgoing is always zero, so that issue is confirmed.

but the original issue is another, which i can't reproduce. can you add more info if you still can reproduce this?

Florian Dold

2024-02-19 21:51

manager   ~0021381

I should've fixed this yesterday actually.

MarcS

2024-02-21 21:00

developer   ~0021433

I can confirm that deposit tx now are reported in Balances / pendingOutgoing and in getTransactions

Issue History

Date ModifiedUsernameFieldChange
2024-02-18 19:52MarcSNew Issue
2024-02-18 19:52MarcSStatusnew => assigned
2024-02-18 19:52MarcSAssigned To => sebasjm
2024-02-19 11:08MarcSRelationship addedchild of 0008237
2024-02-19 11:52sebasjmProduct Version => git (master)
2024-02-19 11:52sebasjmTarget Version => 0.9.4
2024-02-19 18:32sebasjmNote Added: 0021379
2024-02-19 18:41sebasjmAssigned Tosebasjm => MarcS
2024-02-19 18:41sebasjmStatusassigned => feedback
2024-02-19 18:41sebasjmNote Added: 0021380
2024-02-19 21:51Florian DoldNote Added: 0021381
2024-02-21 21:00MarcSNote Added: 0021433
2024-02-21 21:01MarcSStatusfeedback => informing
2024-02-21 21:01MarcSResolutionopen => fixed
2024-03-07 19:52Christian GrothoffFixed in Version => 0.9.4
2024-03-07 19:52Christian GrothoffStatusinforming => closed