View Issue Details

IDProjectCategoryView StatusLast Update
0008407Talerwallet-corepublic2024-04-15 19:32
ReporterMarcS Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PriorityhighSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Target Version0.10Fixed in Version0.10 
Summary0008407: report outdated coins with a correct error and reduce balance when denominations become unoffered [estimate: 5h]
Descriptionwallet.ts finished wallet core request initiatePeerPushDebit with error: {
  "code": 7027,
  "when": { "t_ms": 1707995490234 },
  "hint": "Error (WALLET_PEER_PUSH_PAYMENT_INSUFFICIENT_BALANCE)",
  "insufficientBalanceDetails": {
    "amountRequested": "KUDOS:1",
    "balanceAvailable": "KUDOS:5.99",
    "balanceMaterial": "KUDOS:5.99",
    "feeGapEstimate": "KUDOS:1",
    "perExchange": {
      "https://exchange.demo.taler.net/": {
        "balanceAvailable": "KUDOS:5.99",
        "balanceMaterial": "KUDOS:5.99",
        "feeGapEstimate": "KUDOS:1"
  } } } }


DEMO was nuked and all denominations made invalid.
wallet-core should report invalid coins as early as possible (e.g. at fee calculation: checkPeerPushDebit), and clearly stating the denominations are invalid instead of waiting till initiatePeerPushDebit and returning the wrong error WALLET_PEER_PUSH_PAYMENT_INSUFFICIENT_BALANCE
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

has duplicate 0008301 closedFlorian Dold wallet-core must reduce balance if denominations become unoffered 
has duplicate 0007930 closedFlorian Dold wallet user should have a clear workaround if the exchange keys are no longer offered by the exchange 

Activities

Florian Dold

2024-02-15 12:10

manager   ~0021306

Here the big question is: How do we report this? As a loss transaction? Via some "error report/notification" concept?

MarcS

2024-02-22 09:42

developer   ~0021444

We forgot to discuss this in the last developer mumble. Please put it in your agenda for the next...

Florian Dold

2024-02-22 10:00

manager   ~0021445

Relevant for this: https://docs.taler.net/design-documents/055-wallet-problem-report.html

Florian Dold

2024-03-28 12:06

manager   ~0022030

Actually we want to show this as a transaction. Or rather as a pair of transactions, should the unoffered coin become available again.

We need a new object store to group coins of unoffered denominations into one.

Florian Dold

2024-03-31 16:13

manager   ~0022064

Implemented in wallet-core.git eb2c8d948

Issue History

Date ModifiedUsernameFieldChange
2024-02-15 11:21MarcSNew Issue
2024-02-15 11:21MarcSStatusnew => assigned
2024-02-15 11:21MarcSAssigned To => Florian Dold
2024-02-15 12:10Florian DoldNote Added: 0021306
2024-02-15 13:52Florian DoldTarget Version => 0.10
2024-02-22 09:42MarcSNote Added: 0021444
2024-02-22 10:00Florian DoldNote Added: 0021445
2024-02-29 23:30Florian DoldSummaryReport outdated coins ASAP, with a correct error => report outdated coins with a correct error and reduce balance when denominations become unoffered
2024-02-29 23:31Florian DoldRelationship addedhas duplicate 0008301
2024-03-07 23:52Florian DoldRelationship addedhas duplicate 0007930
2024-03-08 21:39Florian DoldPrioritynormal => high
2024-03-27 20:16Florian DoldSummaryreport outdated coins with a correct error and reduce balance when denominations become unoffered => report outdated coins with a correct error and reduce balance when denominations become unoffered [estimate: 6h]
2024-03-28 12:06Florian DoldNote Added: 0022030
2024-03-31 16:07Florian DoldSummaryreport outdated coins with a correct error and reduce balance when denominations become unoffered [estimate: 6h] => report outdated coins with a correct error and reduce balance when denominations become unoffered [estimate: 5h]
2024-03-31 16:13Florian DoldStatusassigned => informing
2024-03-31 16:13Florian DoldResolutionopen => fixed
2024-03-31 16:13Florian DoldNote Added: 0022064
2024-04-09 11:11Christian GrothoffFixed in Version => 0.10
2024-04-15 19:32Christian GrothoffStatusinforming => closed