View Issue Details

IDProjectCategoryView StatusLast Update
0008374Talerwallet-corepublic2024-03-05 22:43
Reporteravalos Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityfeatureReproducibilityalways
Status closedResolutionwon't fix 
Platformarm64OSLineageOSOS Version18.1
Product Versiongit (master) 
Target Version0.10 
Summary0008374: Add currencySpecification to getBalances response
DescriptionCurrently, in order to get the currencySpecification of all the balances in the wallet, I need to make a separate getCurrencySpecification request for each balance (using its scopeInfo as an argument). This is not the most optimal approach. wallet-core already knows the relationship between balance -> scopeInfo -> currencySpecification, so why not give it to us in advance? :)
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2024-03-05 22:43

manager   ~0021707

We should keep each API call simple and specific, and there could even be cases (like wallet-cli) where we don't even want to show the currency specs. I think it is fine to require dedicated calls when a currency spec is needed. Keeps the individual calls simple instead of returning possibly completely unnecessary data. For example, you may also call getBalances *a lot* (whenever the balance changes), but the currency specs the UIs probably should _cache_ as they are highly unlikely to change during the GUI's runtime :-).

Issue History

Date ModifiedUsernameFieldChange
2024-02-13 01:38avalosNew Issue
2024-02-13 01:38avalosStatusnew => assigned
2024-02-13 01:38avalosAssigned To => Florian Dold
2024-02-13 16:27Florian DoldTarget Versiongit (master) => 0.10
2024-03-05 22:43Christian GrothoffNote Added: 0021707
2024-03-05 22:43Christian GrothoffStatusassigned => closed
2024-03-05 22:43Christian GrothoffResolutionopen => won't fix