View Issue Details

IDProjectCategoryView StatusLast Update
0008331Talerwallet-corepublic2024-03-07 19:49
ReporterFlorian Dold Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritylowSeveritytweakReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.9.4Fixed in Version0.9.4 
Summary0008331: http client lib doesn't transparently follow redirects on nodejs
DescriptionBoth the browser and (presumably?) curl automatically follow redirects, even for POST requests and a 308 status code.

However, the http client lib implementation for NodeJS differs in behavior here, as the NodeJS http library we wrap doesn't follow redirects automatically. We'd need to implement redirect following in our wrapper.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Florian Dold

2024-02-05 22:59

manager   ~0021167

Implemented in wallet-core now, not tested yet.

Florian Dold

2024-02-05 23:00

manager   ~0021168

Christian: Do test cases pass with the redirect in the merchant backend? You need to have wallet-core with at least commit 78ba50dadceb.

Christian Grothoff

2024-02-05 23:14

manager   ~0021169

Nope, 2 fail. Details on mattermost.

Florian Dold

2024-02-08 09:10

manager   ~0021206

Redirects are now handled transparently via the follow-redirects package on NodeJS.

Issue History

Date ModifiedUsernameFieldChange
2024-02-05 22:42Florian DoldNew Issue
2024-02-05 22:42Florian DoldStatusnew => assigned
2024-02-05 22:42Florian DoldAssigned To => Florian Dold
2024-02-05 22:59Florian DoldNote Added: 0021167
2024-02-05 22:59Florian DoldAssigned ToFlorian Dold => Christian Grothoff
2024-02-05 23:00Florian DoldNote Added: 0021168
2024-02-05 23:14Christian GrothoffNote Added: 0021169
2024-02-05 23:24Christian GrothoffAssigned ToChristian Grothoff => Florian Dold
2024-02-08 09:10Florian DoldStatusassigned => informing
2024-02-08 09:10Florian DoldResolutionopen => fixed
2024-02-08 09:10Florian DoldNote Added: 0021206
2024-02-08 23:50Christian GrothoffProduct Version => git (master)
2024-02-08 23:50Christian GrothoffFixed in Version => 0.9.4
2024-02-08 23:50Christian GrothoffTarget Version0.10 => 0.9.4
2024-03-07 19:49Christian GrothoffStatusinforming => closed